address review comments

Author: RSingh1511

sanitizers/features/BUILD.bazel

@@ -14,13 +14,12 @@
 load("@rules_cc//cc/toolchains:args.bzl", "cc_args")
 load("@rules_cc//cc/toolchains:feature.bzl", "cc_feature")
 
-# Link flags for ASan + UBSan + LSan combined
+# Compile + link flags for ASan + UBSan + LSan combined
 cc_args(
-    name = "asan_ubsan_lsan_link_args",
+    name = "asan_ubsan_lsan_args",
     actions = [
-        "@rules_cc//cc/toolchains/actions:cpp_link_executable",
-        "@rules_cc//cc/toolchains/actions:cpp_link_dynamic_library",
-        "@rules_cc//cc/toolchains/actions:cpp_link_nodeps_dynamic_library",
+        "@rules_cc//cc/toolchains/actions:compile_actions",
+        "@rules_cc//cc/toolchains/actions:link_actions",
     ],
     args = [
         "-fsanitize=undefined,address,leak",
@@ -32,17 +31,16 @@ cc_args(
 cc_feature(
     name = "asan_ubsan_lsan_link",
     feature_name = "asan_ubsan_lsan_link",
-    args = [":asan_ubsan_lsan_link_args"],
+    args = [":asan_ubsan_lsan_args"],
     visibility = ["//visibility:public"],
 )
 
-# Link flags for ThreadSanitizer
+# Compile + link flags for ThreadSanitizer
 cc_args(
-    name = "tsan_link_args",
+    name = "tsan_args",
     actions = [
-        "@rules_cc//cc/toolchains/actions:cpp_link_executable",
-        "@rules_cc//cc/toolchains/actions:cpp_link_dynamic_library",
-        "@rules_cc//cc/toolchains/actions:cpp_link_nodeps_dynamic_library",
+        "@rules_cc//cc/toolchains/actions:compile_actions",
+        "@rules_cc//cc/toolchains/actions:link_actions",
     ],
     args = [
         "-fsanitize=thread",
@@ -54,6 +52,6 @@ cc_args(
 cc_feature(
     name = "tsan_link",
     feature_name = "tsan_link",
-    args = [":tsan_link_args"],
+    args = [":tsan_args"],
     visibility = ["//visibility:public"],
 )

sanitizers/templates/asan_ubsan_lsan.env.template

@@ -1,3 +1,3 @@
-ASAN_OPTIONS=exitcode=55 allow_addr2line=1 verbosity=1 check_initialization_order=1 detect_stack_use_after_return=1 print_stats=1 halt_on_error=1 allocator_may_return_null=1 detect_leaks=1 suppressions=%ROOT%sanitizers/suppressions/asan.supp
-UBSAN_OPTIONS=exitcode=55 allow_addr2line=1 verbosity=1 print_stacktrace=1 halt_on_error=1 suppressions=%ROOT%sanitizers/suppressions/ubsan.supp
+ASAN_OPTIONS=allocator_may_return_null=1 allow_addr2line=1 check_initialization_order=1 detect_leaks=1 detect_stack_use_after_return=1 exitcode=55 halt_on_error=1 print_stats=1 strict_string_checks=1 verbosity=1 suppressions=%ROOT%sanitizers/suppressions/asan.supp
+UBSAN_OPTIONS=allow_addr2line=1 exitcode=55 halt_on_error=1 print_stacktrace=1 verbosity=1 suppressions=%ROOT%sanitizers/suppressions/ubsan.supp
 LSAN_OPTIONS=exitcode=55 suppressions=%ROOT%sanitizers/suppressions/lsan.supp

sanitizers/templates/tsan.env.template

@@ -1 +1 @@
-TSAN_OPTIONS=exitcode=55 allow_addr2line=1 verbosity=1 detect_deadlocks=1 second_deadlock_stack=1 halt_on_error=1 suppressions=%ROOT%sanitizers/suppressions/tsan.supp
+TSAN_OPTIONS=allow_addr2line=1 detect_deadlocks=1 exitcode=55 halt_on_error=1 second_deadlock_stack=1 verbosity=1 suppressions=%ROOT%sanitizers/suppressions/tsan.supp