Add optional output suffix to fckit_target_preprocess_fypp#92
Merged
wdeconinck merged 1 commit intoMay 18, 2026
Merged
Conversation
Contributor
Author
|
Hi @wdeconinck, could you please review? Thanks! |
wdeconinck
approved these changes
May 18, 2026
Member
wdeconinck
left a comment
There was a problem hiding this comment.
Thanks @awnawab that looks nice!
Member
|
This needs to be rebased on develop first, which will solve the errors we're seeing. |
99b5682 to
b1b4d93
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #92 +/- ##
========================================
Coverage 51.07% 51.07%
========================================
Files 58 58
Lines 4854 4854
Branches 453 453
========================================
Hits 2479 2479
Misses 2375 2375 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contributes an optional
OUTPUT_SUFFIXto thefckit_target_preprocess_fyppmacro, typically to be used when building multiple precision variants of the same target.