Skip to content

Add optional output suffix to fckit_target_preprocess_fypp#92

Merged
wdeconinck merged 1 commit into
ecmwf:developfrom
awnawab:feature/fckit_preprocess_output_suffix
May 18, 2026
Merged

Add optional output suffix to fckit_target_preprocess_fypp#92
wdeconinck merged 1 commit into
ecmwf:developfrom
awnawab:feature/fckit_preprocess_output_suffix

Conversation

@awnawab
Copy link
Copy Markdown
Contributor

@awnawab awnawab commented May 18, 2026

This PR contributes an optional OUTPUT_SUFFIX to the fckit_target_preprocess_fypp macro, typically to be used when building multiple precision variants of the same target.

@awnawab
Copy link
Copy Markdown
Contributor Author

awnawab commented May 18, 2026

Hi @wdeconinck, could you please review? Thanks!

Copy link
Copy Markdown
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @awnawab that looks nice!

@wdeconinck wdeconinck added the approved-for-ci Approved for CI run label May 18, 2026
@wdeconinck
Copy link
Copy Markdown
Member

This needs to be rebased on develop first, which will solve the errors we're seeing.

@awnawab awnawab force-pushed the feature/fckit_preprocess_output_suffix branch from 99b5682 to b1b4d93 Compare May 18, 2026 09:42
@github-actions github-actions Bot removed the approved-for-ci Approved for CI run label May 18, 2026
@wdeconinck wdeconinck added the approved-for-ci Approved for CI run label May 18, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.07%. Comparing base (08b56d1) to head (b1b4d93).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #92   +/-   ##
========================================
  Coverage    51.07%   51.07%           
========================================
  Files           58       58           
  Lines         4854     4854           
  Branches       453      453           
========================================
  Hits          2479     2479           
  Misses        2375     2375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wdeconinck wdeconinck merged commit 1e05dc8 into ecmwf:develop May 18, 2026
181 of 190 checks passed
wdeconinck added a commit that referenced this pull request May 18, 2026
* hotfix/0.14.3:
  Version 0.14.3
  fckit_target_preprocess: add optional OUTPUT_SUFFIX argument (#92)
  Install a fckit_venv symlink to build/fckit_venv if FCKIT_VENV_INSTALL=OFF (#90)
  fckit_yaml_reader: relax ruamel version spec (#87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants