Skip to content

PHP 8.1 deprecated in CachedFile.php #10

@udi111

Description

@udi111

Hi,

PHP Deprecated: Implicit conversion from float to int loses precision in CachedFile.php

      if ($original_ratio >= $preview_ratio) {
        $preview_height = $original_height * $preview_width / $original_width;
      }
      else {
        $preview_width = $original_width * $preview_height / $original_height;
      }

should be floored:

      if ($original_ratio >= $preview_ratio) {
        $preview_height = floor($original_height * $preview_width / $original_width);
      }
      else {
        $preview_width = floor($original_width * $preview_height / $original_height);
      }

cheers

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions