From 59ac92e7b6983362cc0c3fc860640adaa6c1fcbc Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Mon, 30 Mar 2026 12:40:53 -0500 Subject: [PATCH 1/2] Fix `maybe_backfill(limit=...)` description Incorrectly labeled in https://github.com/matrix-org/synapse/pull/13535). `maybe_backfill` already accurately describes `limit` (inroduced in https://github.com/matrix-org/synapse/pull/8349) --- synapse/handlers/federation.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/synapse/handlers/federation.py b/synapse/handlers/federation.py index 14805ac80f7..ffff89c29c8 100644 --- a/synapse/handlers/federation.py +++ b/synapse/handlers/federation.py @@ -242,7 +242,9 @@ async def _maybe_backfill_inner( Args: room_id: The room to backfill in. current_depth: The depth to check at for any upcoming backfill points. - limit: The max number of events to request from the remote federated server. + limit: The number of events that the pagination request will + return. This is used as part of the heuristic to decide if we + should back paginate. processing_start_time: The time when `maybe_backfill` started processing. Only used for timing. If `None`, no timing observation will be made. From 5fab3bab3d4d298db78c436e2ddc0eed1690d0df Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Mon, 30 Mar 2026 12:45:27 -0500 Subject: [PATCH 2/2] Add changelog --- changelog.d/19630.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/19630.misc diff --git a/changelog.d/19630.misc b/changelog.d/19630.misc new file mode 100644 index 00000000000..3d2b787f5f4 --- /dev/null +++ b/changelog.d/19630.misc @@ -0,0 +1 @@ +Fix docstring for `limit` argument in `_maybe_backfill_inner(...)`.