Skip to content

Improve default logo handling somehow #3

@rhoerr

Description

@rhoerr

Right now this module forceably overrides the default logo/icon to Magento's generic magento-logo/magento-icon if none is defined.

<?php if ($adminLogoViewModel->isAdminLoginPage()): ?>
src="<?= $escaper->escapeUrl(
$adminLoginLogoSrc ?: $block->getViewFileUrl('images/magento-logo.svg')
); ?>"
<?php else: ?>
src="<?= $escaper->escapeUrl(
$adminMenuLogoSrc ?: $block->getViewFileUrl('images/magento-icon.svg')
); ?>"
<?php endif; ?>

This works but is kind of limiting. If installed on Adobe Commerce or Mage-OS, it'll mean Magento's logo pops in rather than the distribution's alternative.

It would be nice to resolve that in some way, either

  • Falling back to default behavior in some way if a custom logo/icon isn't defined, to preserve whatever is there out of box, or
  • Creating some way to gracefully change the defaults, that others (Adobe Commerce, Mage-OS, Hyva Commerce, etc.) can hook onto.

I would like to integrate this module into Mage-OS by default in May (3.0), but this is a blocker we need to overcome in some way before that's an option.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions