-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Right now this module forceably overrides the default logo/icon to Magento's generic magento-logo/magento-icon if none is defined.
module-custom-admin-logo/view/adminhtml/templates/page/header.phtml
Lines 30 to 38 in f80a23a
| <?php if ($adminLogoViewModel->isAdminLoginPage()): ?> | |
| src="<?= $escaper->escapeUrl( | |
| $adminLoginLogoSrc ?: $block->getViewFileUrl('images/magento-logo.svg') | |
| ); ?>" | |
| <?php else: ?> | |
| src="<?= $escaper->escapeUrl( | |
| $adminMenuLogoSrc ?: $block->getViewFileUrl('images/magento-icon.svg') | |
| ); ?>" | |
| <?php endif; ?> |
This works but is kind of limiting. If installed on Adobe Commerce or Mage-OS, it'll mean Magento's logo pops in rather than the distribution's alternative.
It would be nice to resolve that in some way, either
- Falling back to default behavior in some way if a custom logo/icon isn't defined, to preserve whatever is there out of box, or
- Creating some way to gracefully change the defaults, that others (Adobe Commerce, Mage-OS, Hyva Commerce, etc.) can hook onto.
I would like to integrate this module into Mage-OS by default in May (3.0), but this is a blocker we need to overcome in some way before that's an option.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels