Skip to content

Remove assert.expect from tests #398

@elwayman02

Description

@elwayman02

Nearly all of our tests call assertions synchronously - that is, they aren't wrapped in callbacks or other scenarios where it's possible that one or more of the assertions won't get called. As a result, using assert.expect becomes unnecessary, since we'll never have a scenario where only some of the assertions get run. We should remove assert.expect from all tests of this nature to make our tests less brittle to future changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomershelp wantedExtra attention is neededinternalInternal changes that don't affect public API

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions