Skip to content

Commit 3a52495

Browse files
committed
fix: correct mixing valve alias and remove unused TOU status validator
1 parent 1fa35ac commit 3a52495

4 files changed

Lines changed: 11 additions & 4 deletions

File tree

README.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ Basic Usage
5252
if device:
5353
# Access status information
5454
status = device.status
55-
print(f"Water Temperature: {status.dhwTemperature}°F")
56-
print(f"Tank Charge: {status.dhwChargePer}%")
57-
print(f"Power Consumption: {status.currentInstPower}W")
55+
print(f"Water Temperature: {status.dhw_temperature}°F")
56+
print(f"Tank Charge: {status.dhw_charge_per}%")
57+
print(f"Power Consumption: {status.current_inst_power}W")
5858
5959
# Set temperature
6060
await api_client.set_device_temperature(device, 130)

src/nwp500/device_capabilities.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ class DeviceCapabilityChecker:
4242
"program_reservation_use": lambda f: bool(f.program_reservation_use),
4343
"recirculation_use": lambda f: bool(f.recirculation_use),
4444
"recirc_reservation_use": lambda f: bool(f.recirc_reservation_use),
45+
"anti_legionella_setting_use": lambda f: bool(
46+
f.anti_legionella_setting_use
47+
),
4548
}
4649

4750
@classmethod

src/nwp500/mqtt_device_control.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,7 @@ async def set_dhw_mode(
366366
device, CommandCode.DHW_MODE, "dhw-mode", param
367367
)
368368

369+
@requires_capability("anti_legionella_setting_use")
369370
async def enable_anti_legionella(
370371
self, device: Device, period_days: int
371372
) -> int:
@@ -375,6 +376,7 @@ async def enable_anti_legionella(
375376
device, CommandCode.ANTI_LEGIONELLA_ON, "anti-leg-on", [period_days]
376377
)
377378

379+
@requires_capability("anti_legionella_setting_use")
378380
async def disable_anti_legionella(self, device: Device) -> int:
379381
"""Disable the Anti-Legionella disinfection cycle."""
380382
return await self._mode_command(

tests/test_device_capabilities.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ def test_get_available_controls(self) -> None:
8282
mock_feature.program_reservation_use = False
8383
mock_feature.recirculation_use = True
8484
mock_feature.recirc_reservation_use = False
85+
mock_feature.anti_legionella_setting_use = True
8586

8687
controls = DeviceCapabilityChecker.get_available_controls(mock_feature)
8788

@@ -92,7 +93,8 @@ def test_get_available_controls(self) -> None:
9293
assert controls["program_reservation_use"] is False
9394
assert controls["recirculation_use"] is True
9495
assert controls["recirc_reservation_use"] is False
95-
assert len(controls) == 7
96+
assert controls["anti_legionella_setting_use"] is True
97+
assert len(controls) == 8
9698

9799
def test_register_capability(self) -> None:
98100
"""Test custom capability registration."""

0 commit comments

Comments
 (0)