Hard-coded values

[KiyofumiTakaba]

These parameters are distributed over several places in the current source code or should become more easily modifiable. I hope them to be reorganized with the reference to redis (or another unified configuration file). Some others may be overlooked.

• pixel size (0.075)
  metadata_uploader/metadata_update_server.py
  ui_components/file_operations/hdf5_file.py
  ui_components/tem_controls/tem_action.py
  ui_components/tem_controls/toolbox/tool.py

• angles between the stage Tx and detector Y
  https://github.com/epoc-ed/GUI/blob/feature/clickonmove/jungfrau_gui/ui_components/tem_controls/toolbox/config.py

class others:
    ### will be removed when these are registered in the dataserver
    rotation_axis_theta = 21.8 # parser['rotation_axis_theta']
    rotation_axis_theta_lm1200x = 52.86 # hopefully be replaced with values for each mag

• default value for end angle of rotation
  ui_components/tem_controls/ui_tem_specific.py

179     self.update_end_angle.setValue(60) # will be replaced with configuration file

• frequency of communication with TEM
  jungfrau_gui/ui_components/tem_controls/tem_action.py

118         self.timer_tem_connexion.start(2000)

• delay (in sec) for starting illumination and data-recording
  ui_components/tem_controls/task/record_task.py

111         self.client.Setf1OverRateTxNum(phi_dot_idx)
112         time.sleep(1) 
113         self.client.SetBeamBlank(0)
114         time.sleep(0.5)

• frequency in checking the stage status during the rotation measurement
  ui_components/tem_controls/task/record_task.py

146                     logfile.write(f"{t - t0:20.6f}  {pos[3]:8.3f} deg\n")
147                     time.sleep(0.1)

[KiyofumiTakaba]

• JFJ software version
  jfj_integration/jungfrau_gui/metadata_uploader/metadata_update_server.py

82        jfj_version = "1.0.0-rc.24"

[KiyofumiTakaba]

GUI/jungfrau_gui/ui_main_window.py

Line 264 in fbb3a2f

def should_update_levels(self, new_low, new_high, tolerance=0.25, abs_wiggle_low = 100):

[erikfrojdh]

I agree having one source of these (and any variables/constants). Probably the redis database it the best place to put it. Only time to be careful is if we query the values very frequently, then we might have to read from redis on init.