Errors in console for 'troubleshooting information' admin page

[thmo]

When calling the 'troubleshooting information' admin page (i.e. the /admin/plugins/info URL), I see these messages in the log:

[ERROR] console - Failed to load 'ep_font_color/static/js/index' for 'ep_font_color/main/client_hooks/postAceInit': ReferenceError: window is not defined
[ERROR] console - Failed to load 'ep_font_color/static/js/index' for 'ep_font_color/main/client_hooks/aceInitialized': ReferenceError: window is not defined
[ERROR] console - Failed to load 'ep_font_color/static/js/index' for 'ep_font_color/main/client_hooks/aceEditorCSS': ReferenceError: window is not defined
[ERROR] console - Failed to load 'ep_font_color/static/js/index' for 'ep_font_color/main/client_hooks/aceCreateDomLine': ReferenceError: window is not defined
[ERROR] console - Failed to load 'ep_font_color/static/js/index' for 'ep_font_color/main/client_hooks/aceAttribsToClasses': ReferenceError: window is not defined

ep_font_color 0.0.24 (installed via npm install)
ep 1.8.6-256-g325941a

[thmo]

Steps to replicate:

$ git clone https://github.com/ether/etherpad-lite.git
$ cd etherpad-lite
$ bin/run.sh
$ npm install ep_font_color
$ echo '{"users":{"admin":{"password":"changeme1","is_admin":true}}}' > credentials.json
$ bin/fastRun.sh

and then, in another terminal:

$ curl --user admin:changeme1 http://0.0.0.0:9001/admin/plugins/info

This is on Fedora 33, with
nodejs-14.14.0-2.fc33.x86_64
npm-6.14.8-1.14.14.0.2.fc33.x86_64

[JohnMcLear]

This was caused by the old code pulling in ep_etherpad-lite/static/js/underscore at module load (which touches window). The plugin was refactored in #126 (commit a5395a2) to use ep_plugin_helpers and no longer touches any browser globals at load time. Verified by requiring ep_font_color/static/js/index in a bare Node process against the current npm version (0.0.119) — all seven hooks load without error. Closing as already fixed.