TASK-033: create_webserver builder cleanup (PRD-CFG-REQ-001..004)

Collapse 17 paired `foo()/no_foo()` setters into single
`foo(bool enable = true)` setters on create_webserver, rename the
remaining one-way negative flags (`no_listen_socket`, `no_thread_safety`,
`no_alpn`) to their positive counterparts (`listen_socket`,
`thread_safety`, `alpn`), and add setter-time validation that throws
`std::invalid_argument` with a parameter-named message:

- port: int overload validates [0, 65535]; uint16_t overload preserved
- max_threads, max_connections, memory_limit, connection_timeout,
  per_IP_connection_limit, max_thread_stack_size, nonce_nc_size,
  listen_backlog, address_reuse, tcp_fastopen_queue_size: reject < 0
- client_discipline_level: reject < -1 (-1 is the unset sentinel)
- file_upload_dir: reject empty string
- bind_address(string): error message now prefixed with "bind_address:"

Header collapsed from 593 lines (feature/v2.0) / 554 lines (master
baseline) to 253 lines — 54% under the v1 baseline (PRD §3.3 target
was 30%). Acceptance grep
`grep -E '^\s*create_webserver& no_' src/httpserver/create_webserver.hpp`
now returns empty. Internal `webserver`-side field names
(`no_listen_socket`, `no_thread_safety`, `no_alpn`) are unchanged so
`webserver.cpp` does not churn — only the public API is renamed.

Tests: new unit tests in test/unit/create_webserver_test.cpp cover
port-out-of-range, every numeric validator, file_upload_dir empty,
bind_address parameter-name message, and the bool-arg shape for every
toggled flag (including the renamed listen_socket/thread_safety/alpn
and widened tcp_nodelay/turbo/suppress_date_header/sigpipe_handled_by_app).
77 tests, 81 checks pass. Full `make check` green (42/42).

Internal callers rewritten: test/integ/ws_start_stop.cpp,
test/integ/file_upload.cpp, test/unit/routing_regression_test.cpp,
examples/file_upload.cpp, examples/external_event_loop.cpp (comment).
README.md updated to document the bool-arg public API.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: etr

README.md

@@ -42,10 +42,10 @@ int main() {
     signal(SIGINT, signal_handler);
 
     // EXTERNAL_SELECT runs MHD without an internal polling thread; the
-    // application drives it via run_wait() below. no_thread_safety() can be
-    // added for a small perf gain when the daemon is only ever touched from
-    // a single thread, but it is omitted here for portability (some MHD
-    // builds, notably Windows/MSYS2, reject that combination at start).
+    // application drives it via run_wait() below. thread_safety(false) can
+    // be added for a small perf gain when the daemon is only ever touched
+    // from a single thread, but it is omitted here for portability (some
+    // MHD builds, notably Windows/MSYS2, reject that combination at start).
     httpserver::webserver ws{httpserver::create_webserver(8080)
         .start_method(httpserver::http::http_utils::EXTERNAL_SELECT)};
 

examples/external_event_loop.cpp

@@ -105,7 +105,7 @@ int main(int argc, char** argv) {
     std::cout << "Please make sure, that the given directory exists and is writeable" << std::endl;
 
     httpserver::webserver ws{httpserver::create_webserver(8080)
-                              .no_put_processed_data_to_content()
+                              .put_processed_data_to_content(false)
                               .file_upload_dir(std::string(argv[1]))
                               .generate_random_filename_on_upload()
                               .file_upload_target(httpserver::FILE_UPLOAD_DISK_ONLY)};

examples/file_upload.cpp

@@ -8,14 +8,14 @@
 Halve the builder's surface by collapsing each paired `foo()/no_foo()` to `foo(bool = true)`, and validate inputs at the build step.
 
 **Action Items:**
-- [ ] Inventory every `no_*` setter in `create_webserver.hpp` (`no_ssl`, `no_debug`, `no_pedantic`, `no_basic_auth`, `no_digest_auth`, `no_deferred`, `no_regex_checking`, `no_ban_system`, `no_post_process`, `no_single_resource`, `no_ipv6`, `no_dual_stack`, etc.).
-- [ ] Replace each with a single `foo(bool enable = true)` setter; remove the corresponding `no_foo()`.
-- [ ] Validate at the setter (or at `webserver` construction) and throw `std::invalid_argument` with a descriptive message:
+- [x] Inventory every `no_*` setter in `create_webserver.hpp` (`no_ssl`, `no_debug`, `no_pedantic`, `no_basic_auth`, `no_digest_auth`, `no_deferred`, `no_regex_checking`, `no_ban_system`, `no_post_process`, `no_single_resource`, `no_ipv6`, `no_dual_stack`, etc.).
+- [x] Replace each with a single `foo(bool enable = true)` setter; remove the corresponding `no_foo()`.
+- [x] Validate at the setter (or at `webserver` construction) and throw `std::invalid_argument` with a descriptive message:
   - port > 65535
   - threads < 0
   - any setter receiving an obviously bogus value (negative timeouts, zero buffer sizes, etc.)
-- [ ] Update internal callers, tests, and examples to use the new boolean-arg form.
-- [ ] Confirm `create_webserver.hpp` line count drops by ≥30% (PRD §3.3 acceptance).
+- [x] Update internal callers, tests, and examples to use the new boolean-arg form.
+- [x] Confirm `create_webserver.hpp` line count drops by ≥30% (PRD §3.3 acceptance).
 
 **Dependencies:**
 - Blocked by: TASK-006, TASK-014
@@ -31,4 +31,4 @@ Halve the builder's surface by collapsing each paired `foo()/no_foo()` to `foo(b
 **Related Requirements:** PRD-CFG-REQ-001, PRD-CFG-REQ-002, PRD-CFG-REQ-003, PRD-CFG-REQ-004
 **Related Decisions:** §4.9
 
-**Status:** Not Started
+**Status:** Done

specs/tasks/M5-routing-lifecycle/TASK-033.md

@@ -115,7 +115,7 @@ Nominally: **13 sequential tasks**, each S–XL. Most other tasks parallelize of
 | TASK-030 | `_handler` suffix renames + `explicit` constructor | M5 | Done | TASK-014 |
 | TASK-031 | Handler error-propagation contract (DR-009) | M5 | Done | TASK-027, TASK-030 |
 | TASK-032 | Thread-safety contract stress test (DR-008) | M5 | Done | TASK-027, TASK-031 |
-| TASK-033 | `create_webserver` builder cleanup | M5 | Not Started | TASK-006, TASK-014 |
+| TASK-033 | `create_webserver` builder cleanup | M5 | Done | TASK-006, TASK-014 |
 | TASK-034 | Build-flag-independent public API + `webserver::features()` | M5 | Not Started | TASK-003, TASK-019, TASK-033 |
 | TASK-035 | Smart-pointer `register_ws_resource` overloads | M5 | Not Started | TASK-014, TASK-034 |
 | TASK-036 | Handler return-by-value dispatch cutover | M5 | Not Started | TASK-022, TASK-025, TASK-027, TASK-031 |

specs/tasks/_index.md

@@ -62,7 +62,7 @@ create_webserver& create_webserver::bind_address(const std::string& ip) {
         return *this;
     }
 
-    throw std::invalid_argument("Invalid IP address: " + ip);
+    throw std::invalid_argument("bind_address: invalid IP address: " + ip);
 }
 
 }  // namespace httpserver