Skip to content

Commit 087695c

Browse files
author
Dylan Huang
committed
propagate error from rollout status
1 parent d130686 commit 087695c

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

eval_protocol/pytest/evaluation_test.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -726,7 +726,10 @@ async def _collect_result(config, lst):
726726

727727
for r in results:
728728
if r.eval_metadata is not None:
729-
r.eval_metadata.status = "finished"
729+
if r.rollout_status.is_error():
730+
r.eval_metadata.status = "error"
731+
else:
732+
r.eval_metadata.status = "finished"
730733
active_logger.log(r)
731734

732735
# for groupwise mode, the result contains eval otuput from multiple completion_params, we need to differentiate them

0 commit comments

Comments
 (0)