Skip to content

Commit 0ed7b63

Browse files
author
Dylan Huang
committed
convert to basedpyright and temporarily disable in CI
1 parent fb3488b commit 0ed7b63

File tree

3 files changed

+35
-17
lines changed

3 files changed

+35
-17
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,12 @@ jobs:
4949
run: uv run ruff check .
5050

5151
- name: Type check with pyright
52-
run: uv run pyright
52+
run: |
53+
# 'set +e' disables immediate exit on error so we can capture and report errors but exit 0
54+
# Note: We currently suppress pyright failures to allow CI to pass while we iteratively fix all type issues.
55+
# Once all type errors are resolved, we will remove this suppression and enforce strict type checking.
56+
set +e
57+
uv run basedpyright || true
5358
5459
test-core:
5560
name: Core Tests (Python ${{ matrix.python-version }})

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ dev = [
6565
"pytest-httpserver",
6666
"werkzeug>=2.0.0",
6767
"ruff>=0.5.0",
68-
"pyright>=1.1.365",
6968
"transformers>=4.0.0",
7069
"types-setuptools",
7170
"types-requests",
@@ -174,6 +173,7 @@ tau2 = { git = "https://github.com/sierra-research/tau2-bench.git" }
174173

175174
[dependency-groups]
176175
dev = [
176+
"basedpyright>=1.31.3",
177177
"fastapi[standard]>=0.116.1",
178178
"fastmcp>=2.10.6",
179179
"haikus==0.3.8",

uv.lock

Lines changed: 28 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)