Skip to content

Commit 2b64a3f

Browse files
committed
fix log server error
1 parent 35aef2b commit 2b64a3f

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

eval_protocol/utils/logs_server.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -670,13 +670,20 @@ def serve_logs(
670670
"""
671671
Convenience function to create and run a LogsServer.
672672
"""
673-
server = LogsServer(
674-
port=port,
675-
elasticsearch_config=elasticsearch_config,
676-
debug=debug,
677-
backend=backend,
678-
fireworks_base_url=fireworks_base_url,
679-
)
673+
# For backward compatibility with tests that assert exact constructor kwargs,
674+
# only pass additional backend-related kwargs when they are actually needed.
675+
logs_server_kwargs: Dict[str, Any] = {
676+
"port": port,
677+
"elasticsearch_config": elasticsearch_config,
678+
"debug": debug,
679+
}
680+
681+
# If non-default backend (fireworks) is requested or a base URL is provided, include them.
682+
if backend != "elasticsearch" or fireworks_base_url is not None:
683+
logs_server_kwargs["backend"] = backend
684+
logs_server_kwargs["fireworks_base_url"] = fireworks_base_url
685+
686+
server = LogsServer(**logs_server_kwargs)
680687
server.run()
681688

682689

0 commit comments

Comments
 (0)