Skip to content

Commit 35db8e2

Browse files
xzrderekxzrderek
authored
store artifacts (#403)
* store artifacts * fix * update * cursor comment * update frontend
1 parent ed22857 commit 35db8e2

10 files changed

Lines changed: 170 additions & 52 deletions

File tree

‎eval_protocol/pytest/remote_rollout_processor.py‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,20 @@ async def _process_row(row: EvaluationRow) -> EvaluationRow:
122122
status_logs.append(log)
123123

124124
if status_logs:
125+
if len(status_logs) > 1:
126+
logger.warning(
127+
"Found %s status logs for rollout %s; expected at most 1. Using the first one: %s",
128+
len(status_logs),
129+
row.execution_metadata.rollout_id,
130+
status_logs[0],
131+
)
125132
# Use the first log with status information
126133
status_log = status_logs[0]
127134
status_dict = status_log.get("status")
135+
raw_extras = status_log.get("extras") or {}
136+
status_extras = {
137+
k: v for k, v in raw_extras.items() if k not in ("logger_name", "level", "timestamp")
138+
}
128139

129140
logger.info(
130141
f"Found status log for rollout {row.execution_metadata.rollout_id}: {status_log.get('message', '')}"
@@ -149,6 +160,11 @@ async def _process_row(row: EvaluationRow) -> EvaluationRow:
149160
details=status_details,
150161
)
151162

163+
if row.execution_metadata.extra:
164+
row.execution_metadata.extra.update(status_extras)
165+
else:
166+
row.execution_metadata.extra = status_extras
167+
152168
logger.info("Stopping polling for rollout %s", row.execution_metadata.rollout_id)
153169
break
154170

‎eval_protocol/pytest/tracing_utils.py‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,18 @@ def update_row_with_remote_trace(
179179
if k not in row.input_metadata.dataset_info:
180180
row.input_metadata.dataset_info[k] = v
181181

182-
row.execution_metadata = remote_row.execution_metadata
182+
preserved_extra = row.execution_metadata.extra
183+
184+
row.execution_metadata = remote_row.execution_metadata.model_copy(deep=True)
185+
186+
if preserved_extra:
187+
if row.execution_metadata.extra:
188+
# Merge remote and local extras; local takes precedence on conflicts
189+
merged = row.execution_metadata.extra or {}
190+
merged.update(preserved_extra)
191+
row.execution_metadata.extra = merged
192+
else:
193+
row.execution_metadata.extra = preserved_extra
183194
return None
184195
else:
185196
raise ValueError("Output data loader should return exactly one row.")

‎vite-app/dist/assets/index-10cZ11iB.js‎

Lines changed: 137 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎vite-app/dist/assets/index-10cZ11iB.js.map‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎vite-app/dist/assets/index-CuQbfdPD.js‎

Lines changed: 0 additions & 46 deletions
This file was deleted.

‎vite-app/dist/assets/index-CuQbfdPD.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎vite-app/dist/assets/index-DOD73Wyg.css‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎vite-app/dist/assets/index-iZp_HgyW.css‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎vite-app/dist/index.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
66
<title>EP | Log Viewer</title>
77
<link rel="icon" href="/assets/favicon-BkAAWQga.png" />
8-
<script type="module" crossorigin src="/assets/index-CuQbfdPD.js"></script>
9-
<link rel="stylesheet" crossorigin href="/assets/index-iZp_HgyW.css">
8+
<script type="module" crossorigin src="/assets/index-10cZ11iB.js"></script>
9+
<link rel="stylesheet" crossorigin href="/assets/index-DOD73Wyg.css">
1010
</head>
1111
<body>
1212
<div id="root"></div>

‎vite-app/src/types/eval-protocol.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ export const ExecutionMetadataSchema = z.object({
351351
.nullable()
352352
.optional()
353353
.describe("Processing duration in seconds for an entire experiment."),
354-
});
354+
}).loose();
355355

356356
export const EvaluationRowSchema = z.object({
357357
messages: z

0 commit comments

Comments
 (0)