Skip to content

Commit 4298470

Browse files
committed
lint
1 parent 10899d8 commit 4298470

File tree

1 file changed

+15
-12
lines changed

1 file changed

+15
-12
lines changed

tests/pytest/test_pytest_evaluator_error_handling.py

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def eval_fn(row: EvaluationRow) -> EvaluationRow:
8383
assert row.evaluation_result is not None
8484
assert row.evaluation_result.score == 0.0
8585
assert row.evaluation_result.is_score_valid is False
86-
assert "Error during evaluation: ValueError: Test error in evaluation function" in row.evaluation_result.reason
86+
assert "Error during evaluation: ValueError: Test error in evaluation function" in row.evaluation_result.reason # pyright: ignore[reportOperatorIssue]
8787

8888
# Check eval_metadata.status was set to score_invalid (due to is_score_valid=False in postprocess)
8989
assert row.eval_metadata is not None
@@ -120,7 +120,7 @@ def eval_fn(row: EvaluationRow) -> EvaluationRow:
120120

121121
# Check error type is included in reason
122122
assert row.evaluation_result is not None
123-
assert "RuntimeError" in row.evaluation_result.reason
123+
assert "RuntimeError" in row.evaluation_result.reason # pyright: ignore[reportOperatorIssue]
124124
# Status will be score_invalid (not error) due to postprocess override
125125
assert row.eval_metadata is not None
126126
assert row.eval_metadata.status is not None
@@ -155,7 +155,7 @@ def eval_fn(row: EvaluationRow) -> EvaluationRow:
155155
assert row.evaluation_result is not None
156156
assert row.evaluation_result.score == 0.0
157157
assert row.evaluation_result.is_score_valid is False
158-
assert "ValueError" in row.evaluation_result.reason
158+
assert "ValueError" in row.evaluation_result.reason # pyright: ignore[reportOperatorIssue]
159159
# Status will be score_invalid due to postprocess
160160
assert row.eval_metadata is not None
161161
assert row.eval_metadata.status is not None
@@ -194,8 +194,8 @@ def eval_fn(row: EvaluationRow) -> EvaluationRow:
194194
row = list(rollouts.values())[0]
195195

196196
assert row.evaluation_result is not None
197-
assert "CustomEvaluationError" in row.evaluation_result.reason
198-
assert "Custom error with details" in row.evaluation_result.reason
197+
assert "CustomEvaluationError" in row.evaluation_result.reason # pyright: ignore[reportOperatorIssue]
198+
assert "Custom error with details" in row.evaluation_result.reason # pyright: ignore[reportOperatorIssue]
199199
# Status will be score_invalid due to postprocess
200200
assert row.eval_metadata is not None
201201
assert row.eval_metadata.status is not None
@@ -229,7 +229,7 @@ def eval_fn(row: EvaluationRow) -> EvaluationRow:
229229
row = list(rollouts.values())[0]
230230

231231
assert row.evaluation_result is not None
232-
assert "Line 1\nLine 2\nLine 3" in row.evaluation_result.reason
232+
assert "Line 1\nLine 2\nLine 3" in row.evaluation_result.reason # pyright: ignore[reportOperatorIssue]
233233

234234

235235
class TestGroupwiseEvaluatorErrorHandling:
@@ -277,7 +277,7 @@ def eval_fn(rows: list[EvaluationRow]) -> list[EvaluationRow]:
277277
assert row.evaluation_result.is_score_valid is False
278278
assert (
279279
"Error during evaluation: ValueError: Test error in groupwise evaluation"
280-
in row.evaluation_result.reason
280+
in row.evaluation_result.reason # pyright: ignore[reportOperatorIssue]
281281
)
282282

283283
# Status will be score_invalid due to postprocess
@@ -320,7 +320,7 @@ def eval_fn(rows: list[EvaluationRow]) -> list[EvaluationRow]:
320320

321321
for row in rollouts.values():
322322
if row.evaluation_result is not None:
323-
assert "RuntimeError" in row.evaluation_result.reason
323+
assert "RuntimeError" in row.evaluation_result.reason # pyright: ignore[reportOperatorIssue]
324324
# Status will be score_invalid due to postprocess
325325
assert row.eval_metadata is not None
326326
assert row.eval_metadata.status is not None
@@ -425,7 +425,9 @@ def eval_fn(row: EvaluationRow) -> EvaluationRow:
425425
row = list(rollouts.values())[0]
426426

427427
assert row.evaluation_result is not None
428-
assert "ValueError" in row.evaluation_result.reason # Should at least have the exception type
428+
assert (
429+
"ValueError" in row.evaluation_result.reason
430+
) # Should at least have the exception type # pyright: ignore[reportOperatorIssue]
429431

430432

431433
class TestEvaluatorErrorHandlingWithInputRows:
@@ -464,7 +466,7 @@ def eval_fn(row: EvaluationRow) -> EvaluationRow:
464466
assert row.evaluation_result is not None
465467
assert row.evaluation_result.score == 0.0
466468
assert row.evaluation_result.is_score_valid is False
467-
assert "ValueError" in row.evaluation_result.reason
469+
assert "ValueError" in row.evaluation_result.reason # pyright: ignore[reportOperatorIssue]
468470
# Status will be score_invalid due to postprocess
469471
assert row.eval_metadata is not None
470472
assert row.eval_metadata.status is not None
@@ -534,9 +536,10 @@ def eval_fn(row: EvaluationRow) -> EvaluationRow:
534536
# Verify reason format in evaluation_result: "Error during evaluation: ExceptionType: message"
535537
assert row.evaluation_result is not None
536538
reason = row.evaluation_result.reason
539+
assert reason is not None
537540
assert reason.startswith("Error during evaluation: ")
538-
assert "KeyError" in reason
539-
assert "missing_key" in reason
541+
assert "KeyError" in reason # pyright: ignore[reportOperatorIssue]
542+
assert "missing_key" in reason # pyright: ignore[reportOperatorIssue]
540543

541544
# Status will be score_invalid, not containing the error details
542545
assert row.eval_metadata is not None

0 commit comments

Comments
 (0)