Skip to content

Commit 67b40d7

Browse files
author
Dylan Huang
committed
fix test_pytest_tools_are_added_to_row
1 parent 2f2bf26 commit 67b40d7

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

tests/pytest/test_pytest_mcp_config.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from typing_extensions import override
12
import pytest
23
from eval_protocol.dataset_logger.dataset_logger import DatasetLogger
34
from eval_protocol.models import EvaluateResult, EvaluationRow, Message
@@ -48,12 +49,16 @@ class TrackingLogger(DatasetLogger):
4849
"""Custom logger that ensures that the final row is in an error state."""
4950

5051
def __init__(self, rollouts: dict[str, EvaluationRow]):
51-
self.rollouts = rollouts
52+
self.rollouts: dict[str, EvaluationRow] = rollouts
5253

54+
@override
5355
def log(self, row: EvaluationRow):
56+
if row.execution_metadata.rollout_id is None:
57+
raise ValueError("Rollout ID is None")
5458
self.rollouts[row.execution_metadata.rollout_id] = row
5559

56-
def read(self):
60+
@override
61+
def read(self, row_id: str | None = None) -> list[EvaluationRow]:
5762
return []
5863

5964
input_messages = [
@@ -82,11 +87,13 @@ def read(self):
8287
def eval_fn(row: EvaluationRow) -> EvaluationRow:
8388
return row
8489

85-
await eval_fn(input_messages=input_messages, completion_params=completion_params_list[0])
90+
await eval_fn(input_messages=input_messages[0], completion_params=completion_params_list[0]) # pyright: ignore[reportCallIssue]
8691

8792
# ensure that the row has tools that were set during AgentRolloutProcessor
8893
assert len(rollouts) == 1
8994
row = list(rollouts.values())[0]
90-
assert sorted([tool["function"].name for tool in row.tools]) == sorted(
95+
if row.tools is None:
96+
raise ValueError("Row has no tools")
97+
assert sorted([tool["function"].name for tool in row.tools]) == sorted( # pyright: ignore[reportAny]
9198
["list_servers", "get_channels", "read_messages"]
9299
)

0 commit comments

Comments
 (0)