Skip to content

Commit 69cb5dc

Browse files
authored
fix: restore logging.basicConfig in test remote servers (#435)
The revert in #434 accidentally removed the `logging.basicConfig(level=logging.INFO)` call from the test remote servers. Without it, the root logger defaults to WARNING, which silently drops the `logger.info()` call that emits `Status.rollout_finished()`. The FireworksTracingHttpHandler never fires, no POST /logs is made, and the RemoteRolloutProcessor polling loop times out after 180 seconds. This restores the original line (with its explanatory comment) in both remote_server.py and remote_server_multi_turn.py. Made-with: Cursor
1 parent 0f3c471 commit 69cb5dc

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

tests/remote_server/remote_server.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313

1414
app = FastAPI()
1515

16+
# Configure logging for the remote server (required for INFO-level logs to be emitted)
17+
logging.basicConfig(level=logging.INFO, format="%(name)s - %(levelname)s - %(message)s")
18+
1619
# Attach Fireworks tracing handler to root logger
1720
fireworks_handler = FireworksTracingHttpHandler()
1821
logging.getLogger().addHandler(fireworks_handler)

tests/remote_server/remote_server_multi_turn.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212

1313
app = FastAPI()
1414

15+
# Configure logging for the remote server (required for INFO-level logs to be emitted)
16+
logging.basicConfig(level=logging.INFO, format="%(name)s - %(levelname)s - %(message)s")
17+
1518
# Attach Fireworks tracing handler to root logger
1619
fireworks_handler = FireworksTracingHttpHandler()
1720
logging.getLogger().addHandler(fireworks_handler)

0 commit comments

Comments
 (0)