Skip to content

Commit 7590778

Browse files
author
Dylan Huang
committed
fix tests
1 parent 873a78a commit 7590778

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

tests/test_status_migration_changes.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,10 @@ def test_trajectory_running_status_creation(self):
8383
row = EvaluationRow(messages=[])
8484

8585
# Simulate the status assignment from MCP execution manager
86-
row.rollout_status = Status(code=Status.Code.OK, message="Rollout is running", details=[])
86+
row.rollout_status = Status(code=Status.Code.RUNNING, message="Rollout is running", details=[])
8787

8888
# Verify the status
89-
assert row.rollout_status.code == Status.Code.OK
89+
assert row.rollout_status.code == Status.Code.RUNNING
9090
assert row.rollout_status.message == "Rollout is running"
9191
assert row.rollout_status.is_running()
9292
assert not row.rollout_status.is_finished()
@@ -278,7 +278,7 @@ def test_status_creation_methods_integration(self):
278278
# Test running status
279279
row.rollout_status = Status.rollout_running()
280280
assert row.rollout_status.is_running()
281-
assert row.rollout_status.code == Status.Code.OK
281+
assert row.rollout_status.code == Status.Code.RUNNING
282282

283283
# Test finished status
284284
row.rollout_status = Status.rollout_finished()
@@ -426,7 +426,7 @@ def test_status_code_compliance(self):
426426

427427
# Test standard gRPC codes
428428
statuses = [
429-
(Status.rollout_running(), Status.Code.OK),
429+
(Status.rollout_running(), Status.Code.RUNNING),
430430
(Status.rollout_finished(), Status.Code.FINISHED), # Custom code
431431
(Status.rollout_error("Test"), Status.Code.INTERNAL),
432432
]

tests/test_status_migration_integration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def test_rollout_status_field_access(self):
3434
row = EvaluationRow(messages=[])
3535

3636
# Should be able to access directly
37-
assert row.rollout_status.code == Status.Code.OK
37+
assert row.rollout_status.code == Status.Code.RUNNING
3838
assert row.rollout_status.message == "Rollout is running"
3939

4040
# Should be able to set directly
@@ -276,7 +276,7 @@ def test_status_code_mapping(self):
276276

277277
# Test different status types and their codes
278278
statuses = [
279-
(Status.rollout_running(), Status.Code.OK),
279+
(Status.rollout_running(), Status.Code.RUNNING),
280280
(Status.rollout_finished(), Status.Code.FINISHED),
281281
(Status.rollout_error("Test"), Status.Code.INTERNAL),
282282
]

tests/test_status_model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def test_status_creation_methods(self):
8282
"""Test the convenience methods for creating Status instances."""
8383
# Test running status
8484
running_status = Status.rollout_running()
85-
assert running_status.code == Status.Code.OK
85+
assert running_status.code == Status.Code.RUNNING
8686
assert running_status.message == "Rollout is running"
8787
assert running_status.details == []
8888

@@ -267,7 +267,7 @@ def test_evaluation_row_default_status(self):
267267
assert not hasattr(row, "status")
268268

269269
# Default status should be running
270-
assert row.rollout_status.code == Status.Code.OK
270+
assert row.rollout_status.code == Status.Code.RUNNING
271271
assert row.rollout_status.message == "Rollout is running"
272272
assert row.rollout_status.details == []
273273

0 commit comments

Comments
 (0)