Remove backwards compatibility methods for rollout status from EvaluationRow and associated tests.

Author: Dylan Huang

eval_protocol/models.py

@@ -576,14 +576,6 @@ def is_trajectory_evaluation(self) -> bool:
             and len(self.evaluation_result.step_outputs) > 0
         )
 
-    def get_rollout_status(self) -> Status:
-        """Get the rollout status (backwards compatibility method)."""
-        return self.rollout_status
-
-    def set_rollout_status(self, status: Status) -> None:
-        """Set the rollout status (backwards compatibility method)."""
-        self.rollout_status = status
-
     def get_conversation_length(self) -> int:
         """Returns the number of messages in the conversation."""
         return len(self.messages)

tests/test_status_migration_integration.py

@@ -42,34 +42,6 @@ def test_rollout_status_field_access(self):
         assert row.rollout_status.code == Status.Code.FINISHED
 
 
-class TestBackwardsCompatibilityMethods:
-    """Test the backwards compatibility methods."""
-
-    def test_get_rollout_status_method(self):
-        """Test the get_rollout_status method."""
-        row = EvaluationRow(messages=[])
-
-        # Method should return the current rollout_status
-        status = row.get_rollout_status()
-        assert status.code == Status.Code.OK
-        assert status.message == "Rollout is running"
-
-        # Should be the same object reference
-        assert status is row.rollout_status
-
-    def test_set_rollout_status_method(self):
-        """Test the set_rollout_status method."""
-        row = EvaluationRow(messages=[])
-
-        # Method should update the rollout_status
-        new_status = Status.rollout_error("Test error")
-        row.set_rollout_status(new_status)
-
-        assert row.rollout_status.code == Status.Code.INTERNAL
-        assert row.rollout_status.message == "Test error"
-        assert row.rollout_status is new_status
-
-
 class TestStatusTransitions:
     """Test transitioning between different status states."""
 

tests/test_status_model.py

@@ -302,21 +302,6 @@ def test_evaluation_row_default_status(self):
         assert row.rollout_status.message == "Rollout is running"
         assert row.rollout_status.details == []
 
-    def test_backwards_compatibility_methods(self):
-        """Test the backwards compatibility methods."""
-        row = EvaluationRow(messages=[])
-
-        # Test get_rollout_status
-        status = row.get_rollout_status()
-        assert status.code == Status.Code.OK
-        assert status.message == "Rollout is running"
-
-        # Test set_rollout_status
-        new_status = Status.rollout_finished()
-        row.set_rollout_status(new_status)
-        assert row.rollout_status.code == Status.Code.FINISHED
-        assert row.rollout_status.message == "Rollout finished"
-
     def test_status_transitions(self):
         """Test transitioning between different status states."""
         row = EvaluationRow(messages=[])