Skip to content

Commit 86af2f9

Browse files
committed
tests fix
1 parent c0c7c8e commit 86af2f9

3 files changed

Lines changed: 25 additions & 7 deletions

File tree

tests/pytest/test_openenv_browsergym_basic.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@
1212
# Skip these integration-heavy tests on CI runners by default
1313
pytestmark = pytest.mark.skipif(os.getenv("CI") == "true", reason="Skip OpenEnv integration tests on CI")
1414

15+
# Skip if OpenEnv not installed
16+
try:
17+
from envs.browsergym_env import BrowserGymEnv, BrowserGymAction # type: ignore
18+
except ImportError:
19+
pytest.skip("OpenEnv browsergym_env not installed", allow_module_level=True)
20+
1521

1622
@pytest.mark.integration
1723
def test_openenv_browsergym_basic():
@@ -43,8 +49,6 @@ def test_openenv_browsergym_basic():
4349

4450
# Construct the processor with a trivial action_parser; the model output will still be generated
4551
# but we parse to a safe noop action to minimize flakiness for the environment step.
46-
from envs.browsergym_env import BrowserGymAction, BrowserGymEnv # type: ignore
47-
4852
processor = OpenEnvRolloutProcessor(
4953
env_factory=None,
5054
prompt_builder=lambda obs, step, history: "Do nothing",

tests/pytest/test_openenv_browsergym_eval.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,12 @@
1010
# Skip these integration-heavy tests on CI runners by default
1111
pytestmark = pytest.mark.skipif(os.getenv("CI") == "true", reason="Skip OpenEnv integration tests on CI")
1212

13+
# Skip if OpenEnv not installed
14+
try:
15+
from envs.browsergym_env import BrowserGymEnv, BrowserGymAction # type: ignore
16+
except ImportError:
17+
pytest.skip("OpenEnv browsergym_env not installed", allow_module_level=True)
18+
1319

1420
def openenv_dataset_to_rows(data: List[Dict[str, Any]]) -> List[EvaluationRow]:
1521
"""

tests/pytest/test_openenv_echo_hub.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,19 @@
99
import pytest
1010

1111

12-
# Preferred import when using the monolithic `openenv` package
13-
from envs.echo_env import EchoEnv # type: ignore
14-
15-
1612
# Skip these integration-heavy tests on CI runners by default
1713
pytestmark = pytest.mark.skipif(os.getenv("CI") == "true", reason="Skip OpenEnv integration tests on CI")
1814

15+
# Try to import, but skip if not available
16+
try:
17+
from envs.echo_env import EchoEnv # type: ignore
18+
19+
_HAS_ECHO = True
20+
except ImportError:
21+
_HAS_ECHO = False
22+
EchoEnv = None # type: ignore
23+
pytest.skip("OpenEnv echo_env not installed", allow_module_level=True)
24+
1925

2026
def echo_dataset_to_rows(data: List[Dict[str, Any]]) -> List[EvaluationRow]:
2127
"""
@@ -79,7 +85,7 @@ def action_parser(response_text: str):
7985
rollout_processor=(
8086
OpenEnvRolloutProcessor(
8187
# Use HF Hub to launch the environment container automatically
82-
env_client_cls=EchoEnv, # type: ignore
88+
env_client_cls=EchoEnv if _HAS_ECHO else None, # type: ignore
8389
hub_repo_id=os.getenv("OPENENV_ECHO_REPO", "openenv/echo-env"),
8490
# Simple prompt+parser above
8591
prompt_builder=prompt_builder,
@@ -88,6 +94,8 @@ def action_parser(response_text: str):
8894
timeout_ms=5000,
8995
num_generations=1,
9096
)
97+
if _HAS_ECHO
98+
else None
9199
),
92100
)
93101
def test_openenv_echo_hub(row: EvaluationRow) -> EvaluationRow:

0 commit comments

Comments
 (0)