remove unused

Author: Dylan Huang

eval_protocol/models.py

@@ -31,8 +31,6 @@ class ErrorInfo(BaseModel):
     # Constants for reason values
     REASON_TERMINATION_REASON: ClassVar[str] = "TERMINATION_REASON"
     REASON_EXTRA_INFO: ClassVar[str] = "EXTRA_INFO"
-    REASON_ROLLOUT_ERROR: ClassVar[str] = "ROLLOUT_ERROR"
-    REASON_STOPPED: ClassVar[str] = "STOPPED"
 
     # Domain constant
     DOMAIN: ClassVar[str] = "evalprotocol.io"
@@ -64,18 +62,6 @@ def extra_info(cls, metadata: Dict[str, Any]) -> "ErrorInfo":
         """Create an ErrorInfo for extra information."""
         return cls(reason=cls.REASON_EXTRA_INFO, domain=cls.DOMAIN, metadata=metadata)
 
-    @classmethod
-    def rollout_error(cls, metadata: Dict[str, Any]) -> "ErrorInfo":
-        """Create an ErrorInfo for rollout errors."""
-        return cls(reason=cls.REASON_ROLLOUT_ERROR, domain=cls.DOMAIN, metadata=metadata)
-
-    @classmethod
-    def stopped_reason(cls, reason: Union[str, TerminationReason]) -> "ErrorInfo":
-        """Create an ErrorInfo for stopped reason."""
-        # Convert TerminationReason enum to string if needed
-        reason_str = reason.value if isinstance(reason, TerminationReason) else reason
-        return cls(reason=cls.REASON_STOPPED, domain=cls.DOMAIN, metadata={"reason": reason_str})
-
 
 class Status(BaseModel):
     """
@@ -156,14 +142,6 @@ def error(cls, error_message: str, details: Optional[List[Dict[str, Any]]] = Non
         """Create a status indicating the rollout failed with an error."""
         return cls(code=cls.Code.INTERNAL, message=error_message, details=details)
 
-    @classmethod
-    def rollout_stopped(cls, message: str, extra_info: Optional[Dict[str, Any]] = None) -> "Status":
-        """Create a status indicating the rollout was stopped."""
-        details = []
-        if extra_info:
-            details.append(ErrorInfo.extra_info(extra_info).to_aip193_format())
-        return cls(code=cls.Code.CANCELLED, message=message, details=details)
-
     def is_running(self) -> bool:
         """Check if the status indicates the rollout is running."""
         return self.code == self.Code.OK and self.message == "Rollout is running"

tests/test_status_migration_changes.py

@@ -290,11 +290,6 @@ def test_status_creation_methods_integration(self):
         assert row.rollout_status.is_error()
         assert row.rollout_status.code == Status.Code.INTERNAL
 
-        # Test stopped status
-        row.rollout_status = Status.rollout_stopped("User stop")
-        assert row.rollout_status.is_stopped()
-        assert row.rollout_status.code == Status.Code.CANCELLED
-
     def test_termination_reason_integration(self):
         """Test integration of termination reason with status."""
         row = EvaluationRow(messages=[])
@@ -434,7 +429,6 @@ def test_status_code_compliance(self):
             (Status.rollout_running(), Status.Code.OK),
             (Status.rollout_finished(), Status.Code.FINISHED),  # Custom code
             (Status.rollout_error("Test"), Status.Code.INTERNAL),
-            (Status.rollout_stopped("Test"), Status.Code.CANCELLED),
         ]
 
         for status, expected_code in statuses:

tests/test_status_migration_integration.py

@@ -71,19 +71,6 @@ def test_running_to_error_transition(self):
         assert not row.rollout_status.is_running()
         assert row.rollout_status.is_error()
 
-    def test_running_to_stopped_transition(self):
-        """Test transition from running to stopped."""
-        row = EvaluationRow(messages=[])
-
-        # Start with running
-        assert row.rollout_status.is_running()
-        assert not row.rollout_status.is_stopped()
-
-        # Transition to stopped
-        row.rollout_status = Status.rollout_stopped("User requested stop")
-        assert not row.rollout_status.is_running()
-        assert row.rollout_status.is_stopped()
-
     def test_error_to_finished_transition(self):
         """Test transition from error to finished."""
         row = EvaluationRow(messages=[])
@@ -292,7 +279,6 @@ def test_status_code_mapping(self):
             (Status.rollout_running(), Status.Code.OK),
             (Status.rollout_finished(), Status.Code.FINISHED),
             (Status.rollout_error("Test"), Status.Code.INTERNAL),
-            (Status.rollout_stopped("Test"), Status.Code.CANCELLED),
         ]
 
         for status, expected_code in statuses:

tests/test_status_model.py

@@ -53,18 +53,6 @@ def test_error_info_factory_methods(self):
         assert extra_error.domain == "evalprotocol.io"
         assert extra_error.metadata == {"steps": 10, "reward": 0.8}
 
-        # Test rollout_error
-        rollout_error = ErrorInfo.rollout_error({"error_code": "E001"})
-        assert rollout_error.reason == "ROLLOUT_ERROR"
-        assert rollout_error.domain == "evalprotocol.io"
-        assert rollout_error.metadata == {"error_code": "E001"}
-
-        # Test stopped_reason
-        stopped_error = ErrorInfo.stopped_reason("user_request")
-        assert stopped_error.reason == "STOPPED"
-        assert stopped_error.domain == "evalprotocol.io"
-        assert stopped_error.metadata["reason"] == "user_request"
-
 
 class TestStatusModel:
     """Test the AIP-193 compatible Status model."""
@@ -121,12 +109,6 @@ def test_status_creation_methods(self):
         assert error_status_with_info.details[0]["domain"] == "evalprotocol.io"
         assert error_status_with_info.details[0]["metadata"] == extra_info
 
-        # Test stopped status
-        stopped_status = Status.rollout_stopped("User requested stop")
-        assert stopped_status.code == Status.Code.CANCELLED
-        assert stopped_status.message == "User requested stop"
-        assert stopped_status.details == []
-
         # Test with termination reason
         termination_status = Status.rollout_finished(TerminationReason.CONTROL_PLANE_SIGNAL)
         assert termination_status.code == Status.Code.FINISHED
@@ -173,13 +155,6 @@ def test_status_helper_methods(self):
         assert error_status.is_error() is True
         assert error_status.is_stopped() is False
 
-        # Test is_stopped
-        stopped_status = Status.rollout_stopped("Test stop")
-        assert stopped_status.is_running() is False
-        assert stopped_status.is_finished() is False
-        assert stopped_status.is_error() is False
-        assert stopped_status.is_stopped() is True
-
     def test_get_termination_reason(self):
         """Test extracting termination reason from status details."""
 
@@ -313,11 +288,6 @@ def test_status_transitions(self):
         assert row.rollout_status.is_error()
         assert not row.rollout_status.is_finished()
 
-        # Transition to stopped
-        row.rollout_status = Status.rollout_stopped("User requested stop")
-        assert row.rollout_status.is_stopped()
-        assert not row.rollout_status.is_error()
-
     def test_termination_reason_integration(self):
         """Test integration of termination reason with status."""
         row = EvaluationRow(messages=[])