Skip to content

Jeed grouping not working #65

Description

@CasualAnimalEnjoyer

Describe the Bug

Jeed grouping not working how it described in the example, and somewhat broken.
Example: Creating a special group

{
  "id": "mypack:basic_fluids",
  "name": "mypack.stack_group.basic_fluids",
  "type": "remi:group",
  "contents": [
    "fluid:minecraft:water",
    "fluid:minecraft:lava",
    "jeed:effect:minecraft:speed"
  ]
}

This will not group jeed effect.
If you hover the mouse over the jeed tab when looking for effect, it will tell you "jeed:effects" but that will not work for the custom group too. The only way to group the jeed effect, through regex like this:

{
  "id": "mypack:basic_fluids",
  "name": "Effects",
  "regexes": [
    "minecraft:speed",
    "minecraft:haste"
  ]
}

Though, any regex like "minecraft:.", ".:speed" will not group at all. Why regex "minecraft:speed" is working? If you check emi.json file in minecraft folder for "lookup history" you could see:

"lookup_history": [
    {
      "id": "minecraft:speed",
      "show_icon": true,
      "neoforge:cures": [
        "milk",
        "protected_by_totem"
      ]
    },
    {
      "type": "fluid",
      "id": "minecraft:water",
      "amount": 0
    },
    {
      "type": "fluid",
      "id": "minecraft:lava",
      "amount": 0
    }
  ]

That's why effects are not working with jeed:effect. They just don't have "type". "Id" only. Fluids are working correctly cause they have the "type".

Maybe jeed changed api or emi deserializing not working as intended. I don't know

Reproduction Steps

  1. Create custom group as normal
  2. Check groups
  3. Only water and lava is grouped

Expected Result

Jeed effect would group with fluids

Screenshots and Videos

Could provide screenshots and logs if necessary

Game Version

1.21.1

Mod Version

4.0.2

Mod Loader

NeoForge

Loader Version

21.1.243

Other Mods / Modpack

  • jeed-1.21-2.3.3 or 2.3.2
  • emi-1.1.24+1.21.1+neoforge
  • yet_another_config_lib_v3-3.8.2+1.21.1-neoforge

Additional Context

P.S. Would be nice to have regex fully working for fluids and effects too

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions