Refactor readers#192
Merged
Merged
Conversation
|
Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_192 |
HendriceH
approved these changes
Dec 11, 2025
Collaborator
HendriceH
left a comment
HendriceH
left a comment
There was a problem hiding this comment.
Looks good. Feel free to commit my cosmetic suggestions before merging.
| forAll(in.boundaryField(), patchi) | ||
| { | ||
| const Foam::fvsPatchField<foam_primitive_t>& pin = in.boundaryField()[patchi]; | ||
| NF_DINFO("Internal: "+std::to_string(nInt)+", Boundary: "+std::to_string(nBnd)+", nFaces: "+std::to_string(nFaces)); |
Collaborator
There was a problem hiding this comment.
Will this work out of the box?
Suggested change
| NF_DINFO("Internal: "+std::to_string(nInt)+", Boundary: "+std::to_string(nBnd)+", nFaces: "+std::to_string(nFaces)); | |
| NeoN::Logging::info("Internal: {}, Boundary: {}, nFaces: {}", nInt, nBnd, nFaces); |
Contributor
Author
There was a problem hiding this comment.
yes, but the we might want to have it as NeoN::Logging::debug which is not yet available. with info it will always print
greole
force-pushed
the
refact/readers
branch
from
c322e5b to
8b3ea6e
Compare
greole
added a commit
to exasim-project/NeoN
that referenced
this pull request
May 13, 2026
Windows build - passing tests by going static, see exasim-project/NeoFOAM#192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the reader/converters from OF fields to NN fields. It is taken out of #155