#19: Remove Lombok (#20)

* #19: Remove Lombok

Author: Sebastian Bär

.github/workflows/ci-build.yml

@@ -1,30 +1,55 @@
 name: CI Build
 
 on:
-  - push
+  push:
+    branches:
+      - main
+  pull_request:
 
 jobs:
   build:
     runs-on: ubuntu-latest
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+      cancel-in-progress: true
     steps:
       - name: Checkout the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - name: Set up JDK 11
-        uses: actions/setup-java@v1
+        uses: actions/setup-java@v3
         with:
+          distribution: 'temurin'
           java-version: 11
-      - name: Cache local Maven repository
-        uses: actions/cache@v2
+          cache: 'maven'
+      - name: Cache SonarCloud packages
+        uses: actions/cache@v3
         with:
-          path: ~/.m2/repository
-          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
-          restore-keys: |
-            ${{ runner.os }}-maven-
+          path: ~/.sonar/cache
+          key: ${{ runner.os }}-sonar
+          restore-keys: ${{ runner.os }}-sonar
+      - name: Enable testcontainer reuse
+        run: echo 'testcontainers.reuse.enable=true' > "$HOME/.testcontainers.properties"
       - name: Run tests and build with Maven
-        run: mvn --batch-mode --update-snapshots clean verify sonar:sonar --file pom.xml -DtrimStackTrace=false -Dsonar.organization=exasol -Dsonar.host.url=https://sonarcloud.io -Dsonar.login=$SONAR_TOKEN
+        run: |
+          mvn --batch-mode clean verify \
+              -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \
+              -DtrimStackTrace=false
+      - name: Publish Test Report
+        uses: scacap/action-surefire-report@v1
+        if: ${{ always() && github.event.pull_request.head.repo.full_name == github.repository && github.actor != 'dependabot[bot]' }}
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+      - name: Sonar analysis
+        if: ${{ env.SONAR_TOKEN != null }}
+        run: |
+          mvn --batch-mode org.sonarsource.scanner.maven:sonar-maven-plugin:sonar \
+              -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \
+              -DtrimStackTrace=false \
+              -Dsonar.organization=exasol \
+              -Dsonar.host.url=https://sonarcloud.io \
+              -Dsonar.login=$SONAR_TOKEN
         env:
-          GITHUB_OAUTH: ${{ secrets.GITHUB_TOKEN }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.github/workflows/release_droid_upload_github_release_assets.yml

@@ -12,21 +12,15 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0
       - name: Set up JDK 11
-        uses: actions/setup-java@v2
+        uses: actions/setup-java@v3
         with:
           distribution: 'temurin'
           java-version: 11
-      - name: Cache local Maven repository
-        uses: actions/cache@v2
-        with:
-          path: ~/.m2/repository
-          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
-          restore-keys: |
-            ${{ runner.os }}-maven-
+          cache: 'maven'
       - name: Build with Maven skipping tests
         run: mvn --batch-mode clean verify -DskipTests
       - name: Generate sha256sum files

.project-keeper.yml

@@ -3,10 +3,4 @@ sources:
     path: pom.xml
     modules:
       - maven_central
-      - lombok
-linkReplacements:
-  - "https://anthonywhitford.com/lombok.maven/lombok-maven-plugin/|https://projectlombok.org/setup/maven"
-excludes:
-  - "E-PK-CORE-18: Outdated content: '.github/workflows/ci-build.yml'"
-  - "E-PK-CORE-18: Outdated content: '.github/workflows/release_droid_upload_github_release_assets.yml'"
-
+excludes:

dependencies.md

@@ -8,80 +8,75 @@
 | [error-reporting-java][0]                       | [MIT][1]                                                 |
 | [JSR 374 (JSON Processing) API][2]              | [Dual license consisting of the CDDL v1.1 and GPL v2][3] |
 | [JSR 374 (JSON Processing) Default Provider][2] | [Dual license consisting of the CDDL v1.1 and GPL v2][3] |
-| [Project Lombok][4]                             | [The MIT License][5]                                     |
 
 ## Test Dependencies
 
-| Dependency                               | License                           |
-| ---------------------------------------- | --------------------------------- |
-| [Hamcrest][6]                            | [BSD License 3][7]                |
-| [EqualsVerifier | release normal jar][8] | [Apache License, Version 2.0][9]  |
-| [JUnit Jupiter Engine][10]               | [Eclipse Public License v2.0][11] |
-| [JUnit Jupiter (Aggregator)][10]         | [Eclipse Public License v2.0][11] |
+| Dependency                               | License                          |
+| ---------------------------------------- | -------------------------------- |
+| [Hamcrest][4]                            | [BSD License 3][5]               |
+| [EqualsVerifier | release normal jar][6] | [Apache License, Version 2.0][7] |
+| [JUnit Jupiter Engine][8]                | [Eclipse Public License v2.0][9] |
+| [JUnit Jupiter (Aggregator)][8]          | [Eclipse Public License v2.0][9] |
 
 ## Plugin Dependencies
 
 | Dependency                                              | License                                        |
 | ------------------------------------------------------- | ---------------------------------------------- |
-| [SonarQube Scanner for Maven][12]                       | [GNU LGPL 3][13]                               |
-| [Apache Maven Compiler Plugin][14]                      | [Apache License, Version 2.0][9]               |
-| [Apache Maven Enforcer Plugin][15]                      | [Apache License, Version 2.0][9]               |
-| [Maven Flatten Plugin][16]                              | [Apache Software Licenese][17]                 |
-| [org.sonatype.ossindex.maven:ossindex-maven-plugin][18] | [ASL2][17]                                     |
-| [Reproducible Build Maven Plugin][19]                   | [Apache 2.0][17]                               |
-| [Maven Surefire Plugin][20]                             | [Apache License, Version 2.0][9]               |
-| [Versions Maven Plugin][21]                             | [Apache License, Version 2.0][9]               |
-| [Apache Maven Deploy Plugin][22]                        | [Apache License, Version 2.0][9]               |
-| [Apache Maven GPG Plugin][23]                           | [Apache License, Version 2.0][9]               |
-| [Apache Maven Source Plugin][24]                        | [Apache License, Version 2.0][9]               |
-| [Apache Maven Javadoc Plugin][25]                       | [Apache License, Version 2.0][9]               |
-| [Nexus Staging Maven Plugin][26]                        | [Eclipse Public License][27]                   |
-| [Lombok Maven Plugin][28]                               | [The MIT License][1]                           |
-| [JaCoCo :: Maven Plugin][29]                            | [Eclipse Public License 2.0][30]               |
-| [error-code-crawler-maven-plugin][31]                   | [MIT][1]                                       |
-| [Project keeper maven plugin][32]                       | [The MIT License][33]                          |
-| [Maven Clean Plugin][34]                                | [The Apache Software License, Version 2.0][17] |
-| [Maven Resources Plugin][35]                            | [The Apache Software License, Version 2.0][17] |
-| [Maven JAR Plugin][36]                                  | [The Apache Software License, Version 2.0][17] |
-| [Maven Install Plugin][37]                              | [The Apache Software License, Version 2.0][17] |
-| [Maven Site Plugin 3][38]                               | [The Apache Software License, Version 2.0][17] |
+| [SonarQube Scanner for Maven][10]                       | [GNU LGPL 3][11]                               |
+| [Apache Maven Compiler Plugin][12]                      | [Apache License, Version 2.0][7]               |
+| [Apache Maven Enforcer Plugin][13]                      | [Apache License, Version 2.0][7]               |
+| [Maven Flatten Plugin][14]                              | [Apache Software Licenese][15]                 |
+| [org.sonatype.ossindex.maven:ossindex-maven-plugin][16] | [ASL2][15]                                     |
+| [Reproducible Build Maven Plugin][17]                   | [Apache 2.0][15]                               |
+| [Maven Surefire Plugin][18]                             | [Apache License, Version 2.0][7]               |
+| [Versions Maven Plugin][19]                             | [Apache License, Version 2.0][7]               |
+| [Apache Maven Deploy Plugin][20]                        | [Apache License, Version 2.0][7]               |
+| [Apache Maven GPG Plugin][21]                           | [Apache License, Version 2.0][7]               |
+| [Apache Maven Source Plugin][22]                        | [Apache License, Version 2.0][7]               |
+| [Apache Maven Javadoc Plugin][23]                       | [Apache License, Version 2.0][7]               |
+| [Nexus Staging Maven Plugin][24]                        | [Eclipse Public License][25]                   |
+| [JaCoCo :: Maven Plugin][26]                            | [Eclipse Public License 2.0][27]               |
+| [error-code-crawler-maven-plugin][28]                   | [MIT][1]                                       |
+| [Project keeper maven plugin][29]                       | [The MIT License][30]                          |
+| [Maven Clean Plugin][31]                                | [The Apache Software License, Version 2.0][15] |
+| [Maven Resources Plugin][32]                            | [The Apache Software License, Version 2.0][15] |
+| [Maven JAR Plugin][33]                                  | [The Apache Software License, Version 2.0][15] |
+| [Maven Install Plugin][34]                              | [The Apache Software License, Version 2.0][15] |
+| [Maven Site Plugin 3][35]                               | [The Apache Software License, Version 2.0][15] |
 
 [0]: https://github.com/exasol/error-reporting-java
 [1]: https://opensource.org/licenses/MIT
 [2]: https://javaee.github.io/jsonp
 [3]: https://oss.oracle.com/licenses/CDDL+GPL-1.1
-[4]: https://projectlombok.org
-[5]: https://projectlombok.org/LICENSE
-[6]: http://hamcrest.org/JavaHamcrest/
-[7]: http://opensource.org/licenses/BSD-3-Clause
-[8]: https://www.jqno.nl/equalsverifier
-[9]: https://www.apache.org/licenses/LICENSE-2.0.txt
-[10]: https://junit.org/junit5/
-[11]: https://www.eclipse.org/legal/epl-v20.html
-[12]: http://sonarsource.github.io/sonar-scanner-maven/
-[13]: http://www.gnu.org/licenses/lgpl.txt
-[14]: https://maven.apache.org/plugins/maven-compiler-plugin/
-[15]: https://maven.apache.org/enforcer/maven-enforcer-plugin/
-[16]: https://www.mojohaus.org/flatten-maven-plugin/
-[17]: http://www.apache.org/licenses/LICENSE-2.0.txt
-[18]: https://sonatype.github.io/ossindex-maven/maven-plugin/
-[19]: http://zlika.github.io/reproducible-build-maven-plugin
-[20]: https://maven.apache.org/surefire/maven-surefire-plugin/
-[21]: http://www.mojohaus.org/versions-maven-plugin/
-[22]: https://maven.apache.org/plugins/maven-deploy-plugin/
-[23]: https://maven.apache.org/plugins/maven-gpg-plugin/
-[24]: https://maven.apache.org/plugins/maven-source-plugin/
-[25]: https://maven.apache.org/plugins/maven-javadoc-plugin/
-[26]: http://www.sonatype.com/public-parent/nexus-maven-plugins/nexus-staging/nexus-staging-maven-plugin/
-[27]: http://www.eclipse.org/legal/epl-v10.html
-[28]: https://anthonywhitford.com/lombok.maven/lombok-maven-plugin/
-[29]: https://www.jacoco.org/jacoco/trunk/doc/maven.html
-[30]: https://www.eclipse.org/legal/epl-2.0/
-[31]: https://github.com/exasol/error-code-crawler-maven-plugin
-[32]: https://github.com/exasol/project-keeper/
-[33]: https://github.com/exasol/project-keeper/blob/main/LICENSE
-[34]: http://maven.apache.org/plugins/maven-clean-plugin/
-[35]: http://maven.apache.org/plugins/maven-resources-plugin/
-[36]: http://maven.apache.org/plugins/maven-jar-plugin/
-[37]: http://maven.apache.org/plugins/maven-install-plugin/
-[38]: http://maven.apache.org/plugins/maven-site-plugin/
+[4]: http://hamcrest.org/JavaHamcrest/
+[5]: http://opensource.org/licenses/BSD-3-Clause
+[6]: https://www.jqno.nl/equalsverifier
+[7]: https://www.apache.org/licenses/LICENSE-2.0.txt
+[8]: https://junit.org/junit5/
+[9]: https://www.eclipse.org/legal/epl-v20.html
+[10]: http://sonarsource.github.io/sonar-scanner-maven/
+[11]: http://www.gnu.org/licenses/lgpl.txt
+[12]: https://maven.apache.org/plugins/maven-compiler-plugin/
+[13]: https://maven.apache.org/enforcer/maven-enforcer-plugin/
+[14]: https://www.mojohaus.org/flatten-maven-plugin/
+[15]: http://www.apache.org/licenses/LICENSE-2.0.txt
+[16]: https://sonatype.github.io/ossindex-maven/maven-plugin/
+[17]: http://zlika.github.io/reproducible-build-maven-plugin
+[18]: https://maven.apache.org/surefire/maven-surefire-plugin/
+[19]: http://www.mojohaus.org/versions-maven-plugin/
+[20]: https://maven.apache.org/plugins/maven-deploy-plugin/
+[21]: https://maven.apache.org/plugins/maven-gpg-plugin/
+[22]: https://maven.apache.org/plugins/maven-source-plugin/
+[23]: https://maven.apache.org/plugins/maven-javadoc-plugin/
+[24]: http://www.sonatype.com/public-parent/nexus-maven-plugins/nexus-staging/nexus-staging-maven-plugin/
+[25]: http://www.eclipse.org/legal/epl-v10.html
+[26]: https://www.jacoco.org/jacoco/trunk/doc/maven.html
+[27]: https://www.eclipse.org/legal/epl-2.0/
+[28]: https://github.com/exasol/error-code-crawler-maven-plugin
+[29]: https://github.com/exasol/project-keeper/
+[30]: https://github.com/exasol/project-keeper/blob/main/LICENSE
+[31]: http://maven.apache.org/plugins/maven-clean-plugin/
+[32]: http://maven.apache.org/plugins/maven-resources-plugin/
+[33]: http://maven.apache.org/plugins/maven-jar-plugin/
+[34]: http://maven.apache.org/plugins/maven-install-plugin/
+[35]: http://maven.apache.org/plugins/maven-site-plugin/

doc/changes/changes_2.1.1.md

@@ -9,6 +9,7 @@ In version 2.1.1 of the `error-code-model-java` we updated dependencies and fixe
 ## Features
 
 * 17: Fixed broken links
+* 19: Removed Lombok from Project
 
 ## Dependency Updates
 
@@ -26,6 +27,7 @@ In version 2.1.1 of the `error-code-model-java` we updated dependencies and fixe
 * Updated `org.apache.maven.plugins:maven-javadoc-plugin:3.3.1` to `3.4.0`
 * Updated `org.codehaus.mojo:versions-maven-plugin:2.8.1` to `2.10.0`
 * Updated `org.jacoco:jacoco-maven-plugin:0.8.7` to `0.8.8`
+* Removed `org.projectlombok:lombok-maven-plugin:1.18.20.0`
 * Added `org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184`
 * Updated `org.sonatype.ossindex.maven:ossindex-maven-plugin:3.1.0` to `3.2.0`
 * Updated `org.sonatype.plugins:nexus-staging-maven-plugin:1.6.8` to `1.6.13`

lombok.config

@@ -32,14 +32,7 @@
         <developerConnection>scm:git:https://github.com/exasol/error-code-model-java.git</developerConnection>
         <url>https://github.com/exasol/error-code-model-java/</url>
     </scm>
-    <dependencies>
-        <dependency>
-            <groupId>org.projectlombok</groupId>
-            <artifactId>lombok</artifactId>
-            <version>1.18.24</version>
-            <scope>provided</scope>
-        </dependency>
-    </dependencies>
+    <dependencies/>
     <build>
         <plugins>
             <plugin>
@@ -238,37 +231,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>org.projectlombok</groupId>
-                <artifactId>lombok-maven-plugin</artifactId>
-                <version>1.18.20.0</version>
-                <executions>
-                    <execution>
-                        <id>delombok-main</id>
-                        <phase>generate-sources</phase>
-                        <goals>
-                            <goal>delombok</goal>
-                        </goals>
-                        <configuration>
-                            <addOutputDirectory>false</addOutputDirectory>
-                            <sourceDirectory>src/main/java</sourceDirectory>
-                            <outputDirectory>target/delombok/main</outputDirectory>
-                        </configuration>
-                    </execution>
-                    <execution>
-                        <id>delombok-test</id>
-                        <phase>generate-test-sources</phase>
-                        <goals>
-                            <goal>testDelombok</goal>
-                        </goals>
-                        <configuration>
-                            <addOutputDirectory>false</addOutputDirectory>
-                            <sourceDirectory>src/test/java</sourceDirectory>
-                            <outputDirectory>target/delombok/test</outputDirectory>
-                        </configuration>
-                    </execution>
-                </executions>
-            </plugin>
             <plugin>
                 <groupId>org.jacoco</groupId>
                 <artifactId>jacoco-maven-plugin</artifactId>
@@ -322,12 +284,6 @@
                         </goals>
                     </execution>
                 </executions>
-                <configuration>
-                    <sourcePaths>
-                        <sourcePath>target/delombok/main</sourcePath>
-                        <sourcePath>target/delombok/test</sourcePath>
-                    </sourcePaths>
-                </configuration>
             </plugin>
         </plugins>
     </build>