From b9266752d55e3e7d9e94055652004b5630274b64 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 20 Oct 2022 13:34:30 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- igor/daemon/backends/files.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/igor/daemon/backends/files.py b/igor/daemon/backends/files.py index e0ea502..e2df1af 100644 --- a/igor/daemon/backends/files.py +++ b/igor/daemon/backends/files.py @@ -152,7 +152,26 @@ def create_item(self, dname, testplan_archive_file): if subdirs != set("plans", "suites"): raise RuntimeError("There must be two top-level dir") - archive.extractall(path=self.__temporary_path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, path=self.__temporary_path) tdir = os.path.join(self.__temporary_path, dname) self.paths.append(tdir)