non-idempotent formatting for overlong parenthesized inline conditionals

[froydnj]

Commit: 0e63875

Input

→ View on rubyfmt.run

# original input
module X
  class Y
    module More
      def test
        # comments make a difference?
        amount = amount_from_api ||
          (Opus::MonetaryFlows::Private::API::BeesItems::ParamTransformer.validation_amount(line_items) if !line_items.nil?)
      end
    end
  end
end

# formatted input from the above
# ought to have been idempotently formatted
module X
  class Y
    module More
      def test
        # comments make a difference?
        amount = amount_from_api ||
          (Opus::MonetaryFlows::Private::API::BeesItems::ParamTransformer.validation_amount(line_items) if !line_items
            .nil?)
      end
    end
  end
end

Output

# original input
module X
  class Y
    module More
      def test
        # comments make a difference?
        amount = amount_from_api ||
          (Opus::MonetaryFlows::Private::API::BeesItems::ParamTransformer.validation_amount(line_items) if !line_items
            .nil?)
      end
    end
  end
end

# formatted input from the above
# ought to have been idempotently formatted
module X
  class Y
    module More
      def test
        # comments make a difference?
        amount = amount_from_api ||
          (if !line_items
              .nil?
            Opus::MonetaryFlows::Private::API::BeesItems::ParamTransformer.validation_amount(line_items)
          end)
      end
    end
  end
end

Expected behavior

Idempotent formatting. Looks like a variant of #813 .

[reese]

This is fixed by #778 FWIW, I think that PR fixes most/all of this class of mod-conditional idempotency stuff since it rips out all of the hacky multiline handling for them.

[reese]

(Fixed by #778)