π logical, neat file structure
π§Ή nice, clean styling
πΈ I like the hover effect on each cheese and that the whole card is a link - good for accessibility
π
CSS file was quite tidy and made sense in terms of where you put the class styles on the page
π€ you've used getStaticProps and getStaticPaths :)
π₯ would have liked to see getServerSideProps for data that will change like quantity of products available (which I realise isn't in your DB schema)
π database schema looks good and makes sense - are you linking users to any other table?
π i notice the single product pages are determined by the cheese name. This results in spaces in the URL.. which doesn't sit right
πΏ Would have liked to see a test
π README could have instructions on setting up locally, i.e. what variables you need in the .env.local and how to set up the local database (without including secrets)
π In terms of semantic HTML, I would make some small changes to improve it. The filter section might be better as an aside. There's a navbar class on a header component..
β I wanted to ask why you used dangerouslySetInnerHTML in the [id].js file
β Why the react-cookie package?
Ultimately, you've done so well. It was a tough project and week and look at how much you've learnt and managed to fix! π π· So keep going! πͺ
π logical, neat file structure
π§Ή nice, clean styling
πΈ I like the hover effect on each cheese and that the whole card is a link - good for accessibility
π CSS file was quite tidy and made sense in terms of where you put the class styles on the page
π€ you've used
getStaticPropsandgetStaticPaths:)π₯ would have liked to see
getServerSidePropsfor data that will change like quantity of products available (which I realise isn't in your DB schema)π database schema looks good and makes sense - are you linking users to any other table?
π i notice the single product pages are determined by the cheese name. This results in spaces in the URL.. which doesn't sit right
πΏ Would have liked to see a test
π README could have instructions on setting up locally, i.e. what variables you need in the .env.local and how to set up the local database (without including secrets)
π In terms of semantic HTML, I would make some small changes to improve it. The filter
sectionmight be better as anaside. There's anavbarclass on aheadercomponent..β I wanted to ask why you used
dangerouslySetInnerHTMLin the[id].jsfileβ Why the
react-cookiepackage?Ultimately, you've done so well. It was a tough project and week and look at how much you've learnt and managed to fix! π π· So keep going! πͺ