Skip to content

More code review stuffΒ #35

@aissshah

Description

@aissshah

πŸ‘ logical, neat file structure
🧹 nice, clean styling
πŸ›Έ I like the hover effect on each cheese and that the whole card is a link - good for accessibility
πŸ’… CSS file was quite tidy and made sense in terms of where you put the class styles on the page
🐀 you've used getStaticProps and getStaticPaths :)
πŸ₯ would have liked to see getServerSideProps for data that will change like quantity of products available (which I realise isn't in your DB schema)
πŸ“š database schema looks good and makes sense - are you linking users to any other table?
πŸ˜• i notice the single product pages are determined by the cheese name. This results in spaces in the URL.. which doesn't sit right
😿 Would have liked to see a test
πŸ“– README could have instructions on setting up locally, i.e. what variables you need in the .env.local and how to set up the local database (without including secrets)
πŸ’‡ In terms of semantic HTML, I would make some small changes to improve it. The filter section might be better as an aside. There's a navbar class on a header component..

❓ I wanted to ask why you used dangerouslySetInnerHTML in the [id].js file
❔ Why the react-cookie package?

Ultimately, you've done so well. It was a tough project and week and look at how much you've learnt and managed to fix! πŸ’ 🌷 So keep going! πŸ’ͺ

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions