[Nexthop] Add BGP thrift definitions#1038
Conversation
induvsuresh
left a comment
There was a problem hiding this comment.
Thank you for the changes, overall lgtm! pls address the inline comments
f7abcb4 to
09c95df
Compare
induvsuresh
left a comment
There was a problem hiding this comment.
We were able to publish the OSS version of bgp_policy.thrift, rib_policy.thrift etc - https://github.com/facebook/fboss/tree/main/configerator/structs/neteng
Could we update the PR to drop these changes and use them directly
Thank you in advance!
55ac725 to
f0a6513
Compare
|
@manoharan-nexthop : I recently synced our BGP open-source ready thrift files in this folder in fboss repo: |
f0a6513 to
82eab0e
Compare
@joseph5wu, The bgp_config.thrift includes Also, the main bgp service thrift file is not available yet which this PR introduces, should we leave that as is, or will you be bringing in that as well. Please let me know. |
|
c22ca75 to
afce7c0
Compare
This commit adds the core BGP service thrift interface along with supporting thrift definitions and build configuration. Files Added: - fboss/bgp/if/bgp_thrift.thrift - Main BGP service interface (TBgpService) defining RPC methods for BGP operations, session management, RIB queries, policy management, and monitoring - fboss/cli/fboss2/commands/show/bgp/summary/bgp_summary.thrift - BGP summary data model for CLI commands - fboss/routing/policy/if/policy_thrift.thrift - Routing policy statistics stub Build System Updates: - CMakeLists.txt - Added thrift compilation targets for BGP thrift files with dependencies on configerator BGP policy and attribute definitions - fboss/bgp/if/BUCK - Thrift library definition for bgp_thrift - fboss/cli/fboss2/commands/show/bgp/summary/BUCK - Thrift library for bgp_summary - fboss/routing/policy/if/BUCK - Thrift library for policy_thrift Dependencies: - Requires configerator BGP policy and attribute thrift definitions - Integrates with fb303 for service monitoring
afce7c0 to
1ce3372
Compare
|
bgp_thrift.thrift and policy_thrift have been published to the fboss OSS repo already, could we re-use that and that way this PR can have just the bgp_summary , its related BUCK and cmake file |
|
Closing this PR, as #1039 already has this change (only this PR now has one thrift file change). |
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Adds the thrift interface definitions for BGP (Border Gateway Protocol) functionality. These thrift files define the data structures and service interfaces needed for BGP operations.
Thrift Files Added:
Build System Updates:
Test Plan