fix

Author: asukaminato0721

pyrefly/lib/lsp/wasm/hover.rs

@@ -549,13 +549,7 @@ pub fn get_hover(
     }
 
     let fallback_name_from_type = fallback_hover_name_from_type(&type_);
-    let (kind, name, docstring_range, module) = if let Some(FindDefinitionItemWithDocstring {
-        metadata,
-        definition_range: definition_location,
-        module,
-        docstring_range,
-        display_name,
-    }) = transaction
+    let hover_definitions = transaction
         .find_definition(
             handle,
             position,
@@ -565,7 +559,14 @@ pub fn get_hover(
             },
         )
         .map(Vec1::into_vec)
-        .unwrap_or_default()
+        .unwrap_or_default();
+    let (kind, name, docstring_range, module) = if let Some(FindDefinitionItemWithDocstring {
+        metadata,
+        definition_range: definition_location,
+        module,
+        docstring_range,
+        display_name,
+    }) = hover_definitions
         // TODO: handle more than 1 definition
         .into_iter()
         .next()

pyrefly/lib/state/lsp.rs

@@ -1596,6 +1596,9 @@ impl<'a> Transaction<'a> {
         position: TextSize,
         covering_nodes: &[AnyNodeRef],
     ) -> Result<Option<(Type, Name)>, EmptyResponseReason> {
+        let module = self
+            .get_module_info(handle)
+            .ok_or(EmptyResponseReason::ModuleInfoNotFound)?;
         // Look up the type of an expression, distinguishing "no answers"
         // from "answers available but no type trace for this range."
         let type_at = |range: TextRange| -> Result<Type, EmptyResponseReason> {
@@ -1680,11 +1683,18 @@ impl<'a> Transaction<'a> {
                     }))
                 }
                 AnyNodeRef::ExprSubscript(subscript) => {
-                    if !Self::position_is_between(
-                        position,
+                    let between = TextRange::new(
                         subscript.value.range().end(),
                         subscript.slice.range().start(),
-                    ) {
+                    );
+                    let suffix = module.code_at(TextRange::new(
+                        subscript.value.range().end(),
+                        subscript.range().end(),
+                    ));
+                    if position >= subscript.slice.range().start()
+                        || !between.contains(position)
+                        || !suffix.chars().next().is_some_and(char::is_whitespace)
+                    {
                         return None;
                     }
                     let dunder_name = match subscript.ctx {

pyrefly/lib/test/lsp/definition.rs

@@ -1203,15 +1203,11 @@ Definition Result:
 
 25 | dict["foo"]
             ^
-Definition Result:
-3632 |     def __getitem__(self, key: _KT, /) -> _VT:
-               ^^^^^^^^^^^
+Definition Result: None
 
 27 | dict["bar"]
             ^
-Definition Result:
-3632 |     def __getitem__(self, key: _KT, /) -> _VT:
-               ^^^^^^^^^^^
+Definition Result: None
 "#
         .trim(),
         report.trim(),

pyrefly/lib/test/lsp/hover.rs

@@ -697,7 +697,7 @@ c[0]
 6 | c[0]
        ^
 ```python
-(attribute) __getitem__: Literal[0]
+Literal[0]
 ```
 "#
         .trim(),