I have a few suggestions here:
- Bug:
pre_option_ping_sites is the wrong hook for what you are trying to achieve, it should be option_ping_sites
- Enh: Update the code to handle both
https and http schemes, see https://core.trac.wordpress.org/ticket/42007
- Well actually:
Some users of the fair plugin may wish to use the pingomattic service as it serves a different purpose than IndexNow. Pingomattic is primarily aimed at notifying RSS services of an update to the RSS feed.
Instead of forbidding FAIR users from using the service (the effect of removing it on option getting), the plugin ought to remove it from the option upon activation of the plugin to allow site owners the freedom to restore it at a later date.
This will also remove the confusion for site owners trying to add it for it to disappear once the option screen reloads.
I'm happy to do a pull request for this ticket once I hear back from you as to whether you'd like to fix the bug or move the change to plugin activation.
I have a few suggestions here:
pre_option_ping_sitesis the wrong hook for what you are trying to achieve, it should beoption_ping_siteshttpsandhttpschemes, see https://core.trac.wordpress.org/ticket/42007Some users of the fair plugin may wish to use the pingomattic service as it serves a different purpose than IndexNow. Pingomattic is primarily aimed at notifying RSS services of an update to the RSS feed.
Instead of forbidding FAIR users from using the service (the effect of removing it on option getting), the plugin ought to remove it from the option upon activation of the plugin to allow site owners the freedom to restore it at a later date.
This will also remove the confusion for site owners trying to add it for it to disappear once the option screen reloads.
I'm happy to do a pull request for this ticket once I hear back from you as to whether you'd like to fix the bug or move the change to plugin activation.