🐞 Bug Report: Add plugins "unexpected error" (FAIR 1.4.0)

[MarkWieczorek]

After installing FAIR 1.4.0, an unexpected error occurs when going to the "add plugin" page. I note that this did not work with the previous version either, but that it did work for me about 6 months ago using a slightly older version of wordpress and FAIR (sorry, I forget which versions). Related to this, it is not possible to upgrade any plugins when FAIR is activated.

Detailed Description

FAIR: 1.4.0
Wordpress: 6.9.4
PHP: 8.3.29

[kasparsd]

@MarkWieczorek would it be possible to share any relevant PHP logs or the wp-content/debug.log content, if WP_DEBUG is enabled, when this error happens?

[MarkWieczorek]

Sure, I'll try later. I suspect that it is the same problem as this: #452

[kasparsd]

I just tried to replicate this with PHP 8.0 and got the following error with the bundled dev environment:

Parse error: syntax error, unexpected identifier "FAIR_FIELDS", expecting "=" in /var/www/html/wp-content/plugins/plugin/vendor/fairpm/did-manager-wordpress/src/FAIR/WordPress/DID/Parsers/PluginHeaderParser.php on line 46

It appears that fairpm/did-manager-wordpress dependency is using a PHP 8.3+ syntax (typed constants) here:

https://github.com/fairpm/did-manager-wordpress/blob/ec9d707414bad62c8fbfdb00e86a79e752a077ac/src/FAIR/WordPress/DID/Parsers/PluginHeaderParser.php#L24

Is that the same issue? Are you running a PHP version below 8.3?

[kasparsd]

Reported an issue fairpm/did-manager-wordpress#4 and a matching fix fairpm/did-manager-wordpress#5

[MarkWieczorek]

I'm using PHP 8.3.29.

[MarkWieczorek]

Here are some messages I got when I enable we_debug and then went to add plugin page:

Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

Warning: Undefined array key 1 in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

Warning: Undefined array key 1 in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

Warning: Undefined array key 1 in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

Warning: Undefined array key 1 in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

Warning: plugins_api(): An unexpected error occurred. Something may be wrong with WordPress.org or this server’s configuration. If you continue to have problems, please try the support forums. (WordPress could not establish a secure connection to WordPress.org. Please contact your server administrator.) in /var/www/wordpress/wp-includes/functions.php on line 6131

Notice: Function WP_Scripts::add was called incorrectly. The script with the handle "recommend-post-smtp-script" was enqueued with dependencies that are not registered: wp-updates. Please see Debugging in WordPress for more information. (This message was added in version 6.9.1.) in /var/www/wordpress/wp-includes/functions.php on line 6131

Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

Warning: Undefined array key 1 in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

Warning: Undefined array key 1 in /var/www/wordpress/wp-content/plugins/fair-plugin/inc/packages/namespace.php on line 694

[kasparsd]

Thanks for sharing those @MarkWieczorek!

This is indeed an issue with package metadata that doesn't include the filename property (such as FAIR plugin itself). I've fixed it in #496.