Fix process management commands on Windows (stop/status/restart)#75
Open
Alexander-He wants to merge 1 commit into
Open
Fix process management commands on Windows (stop/status/restart)#75Alexander-He wants to merge 1 commit into
Alexander-He wants to merge 1 commit into
Conversation
stop, status, and restart commands were broken on Windows because processExists() and stopAllWeclaw() used Unix-only APIs (syscall.Signal(0), syscall.SIGTERM, pkill) without platform build tags. - Move processExists() and stopAllWeclaw() to platform-specific files - proc_unix.go: same Unix implementation (//go:build !windows) - proc_windows.go: use tasklist/taskkill instead of signals/pkill - restart.go: delegate to stopAllWeclaw() instead of duplicating logic Fixes fastclaw-ai#74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
weclaw stop,weclaw status, andweclaw restartare broken on Windows. The functionsprocessExists()andstopAllWeclaw()incmd/start.gouse Unix-only APIs (syscall.Signal(0),syscall.SIGTERM,pkill) with no platform-specific handling.processExists()usesp.Signal(syscall.Signal(0))— on Windows,os.FindProcessalways succeeds and signal 0 is not supported, so this always returns wrong resultsstopAllWeclaw()usesSIGTERMandpkill— neither works on Windowsrestartduplicates the same broken logic inlineChanges
processExists()andstopAllWeclaw()out ofcmd/start.gointo platform-specific files with build tagscmd/proc_unix.go(//go:build !windows) — unchanged Unix implementationcmd/proc_windows.go(//go:build windows) — Windows implementation usingtasklist/taskkillcmd/restart.go— delegate tostopAllWeclaw()instead of duplicating logicTesting
Verified on Windows 11:
weclaw statusnow correctly reports the running PID,weclaw stopactually terminates the process, andweclaw restartworks end-to-end.Closes #74