Address review feedback on resource base class

- Remove unecessary constructor wrapper calls
- Rename _inner to _wit_resource
- Rename module to _resource from resource as private, remove some of
  the internal disclaimers.

Author: posborne

fastly_compute/resource.py fastly_compute/_resource.pyfastly_compute/resource.py renamed to fastly_compute/_resource.py

@@ -19,8 +19,6 @@ class WitResource(Protocol):
 
     This protocol defines the context manager interface that all WIT resources
     must implement for resource lifecycle management.
-
-    **Internal use only** - do not use directly.
     """
 
     def __enter__(self) -> Self:
@@ -44,19 +42,16 @@ class FastlyResource[T: WitResource]:
     resource lifecycle management for all Fastly resource types that wrap
     WIT bindings (e.g., ConfigStore, RateCounter, PenaltyBox, LogEndpoint).
 
-    **Internal use only** - do not instantiate or subclass directly. Use the
-    public resource classes instead (ConfigStore, RateCounter, etc.).
-
     The type parameter T represents the underlying WIT binding resource type
     and must satisfy the WitResource protocol (context manager support).
     """
 
-    def __init__(self, inner: T):
+    def __init__(self, wit_resource: T):
         """Initialize the resource wrapper with an inner WIT binding.
 
-        :param inner: The underlying WIT binding resource to wrap
+        :param wit_resource: The underlying WIT binding resource to wrap
         """
-        self._inner = inner
+        self._wit_resource = wit_resource
 
     def close(self) -> None:
         """Explicitly close the resource, releasing its resources.
@@ -68,7 +63,7 @@ def close(self) -> None:
         Note: Attempting to use the resource after it is closed will result
         in a trap.
         """
-        self._inner.__exit__(None, None, None)
+        self._wit_resource.__exit__(None, None, None)
 
     def __enter__(self) -> Self:
         """Context manager entry.
@@ -101,4 +96,4 @@ def __exit__(
         :param exc_val: Exception value if an exception occurred, None otherwise
         :param exc_tb: Exception traceback if an exception occurred, None otherwise
         """
-        self._inner.__exit__(exc_type, exc_val, exc_tb)
+        self._wit_resource.__exit__(exc_type, exc_val, exc_tb)

fastly_compute/config_store.py

@@ -15,7 +15,7 @@
 
 from wit_world.imports import config_store as wit_config_store
 
-from .resource import FastlyResource
+from ._resource import FastlyResource
 
 # The maximum value for a u32, used to signal that we don't want to cap
 # the length of values returned by the host.  In practice, this limit
@@ -35,10 +35,6 @@ class ConfigStore(FastlyResource[wit_config_store.Store]):
             api_url = config.get("api_url", "https://api.example.com")
     """
 
-    def __init__(self, store: wit_config_store.Store):
-        """Private constructor. Use ConfigStore.open() instead."""
-        super().__init__(store)
-
     @classmethod
     def open(cls, name: str) -> Self:
         """Open a config store by name.
@@ -69,7 +65,7 @@ def get(self, key: str, default: str | None = None) -> str | None:
             config = ConfigStore.open("app-config")
             api_url = config.get("api_url", "https://api.example.com")
         """
-        result = self._inner.get(key, _MAX_U32)
+        result = self._wit_resource.get(key, _MAX_U32)
         if result is None:
             result = default
 

fastly_compute/log.py

@@ -28,7 +28,7 @@
 
 from wit_world.imports import log as wit_log
 
-from .resource import FastlyResource
+from ._resource import FastlyResource
 
 
 class LogEndpoint(FastlyResource[wit_log.Endpoint]):
@@ -44,10 +44,6 @@ class LogEndpoint(FastlyResource[wit_log.Endpoint]):
             endpoint.write(b"Binary log data")
     """
 
-    def __init__(self, endpoint: wit_log.Endpoint):
-        """Private constructor. Use LogEndpoint.open() instead."""
-        super().__init__(endpoint)
-
     @classmethod
     def open(cls, name: str) -> Self:
         r"""Open a logging endpoint by name.
@@ -90,7 +86,7 @@ def write(self, msg: bytes | str) -> None:
         """
         if isinstance(msg, str):
             msg = msg.encode("utf-8")
-        self._inner.write(msg)
+        self._wit_resource.write(msg)
 
 
 class FastlyLogHandler(logging.Handler):