refactor: replace runtime module options with wazero ModuleConfig#46
Open
stephenafamo wants to merge 1 commit into
Open
refactor: replace runtime module options with wazero ModuleConfig#46stephenafamo wants to merge 1 commit into
stephenafamo wants to merge 1 commit into
Conversation
Replace the bespoke runtime module-instantiation fields on qjs.Option with wazero.ModuleConfig and update tests/docs to match.
Author
|
Implements #45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates runtime module-instantiation customization from several ad hoc
qjs.Optionfields towazero.ModuleConfig.Instead of exposing separate
CWD,StartFunctionName,Stdout, andStderrfields,qjs.Optionnow exposes a singleModuleConfigfield for advanced module setup.When
ModuleConfigis nil, qjs now creates a default wazero module config that:WithStartFunctions()/This preserves the previous behavior of
qjs.New()after the refactor.Without explicitly clearing start functions, bare
wazero.NewModuleConfig()would run_startduring instantiation and break normal runtime creation.