write after end

[kilianc]

I took a quick look at the implementation and it looks like all Stream#write() calls are used as if they were synchronous, but they are not.

The result is that we close the stream before all writes are done.

Am I correct? Or there is something that I am missing?

[mariomurrent-softwaresolutions]

You're totally right.

[felixge]

@kilianc is there a bug/problem you have related to this? IIRC the write method in this pkg doesn't implement the callback argument because it isn't quite clear how it should behave, especially when multiple destinations are being piped to.

[kilianc]

@felixge yeah, I put this in my rev-proxy to re-attempt calls with a body and it fails with > 1MB multipart payloads.

[felixge]

@kilianc why is it failing? Is your lib expecting write() to provide a callback?

[kilianc]

@felixge it's a simple pipe. All I get is write after end error from the stream, see the code:

pipe(sourceRequest, cache, targetRequest).on('error', reject)

This runs in a loop if there is a connection/dns/socket/etc error to target request, but the second time fails if the payload is big enough to need a callback.

[Ashoat]

Does anybody know of an alternative that doesn't have the same issues?

[Ashoat]

Following up on this in case it's useful for anybody else: we ended up switching to rereadable-stream and it solved the issue for us.