Merge pull request #13 from fells-code/loginAbstract

Login abstract

Author: Bccorb

package.json

@@ -23,7 +23,7 @@
     "build": "rollup -c",
     "test": "jest",
     "coverage": "npm test -- --coverage",
-    "lint": "eslint ./src",
+    "lint": "eslint ./src ./tests",
     "format": "prettier --write .",
     "prepare": "husky",
     "semantic-release": "semantic-release",

rollup.config.js

@@ -33,7 +33,7 @@ export default [
       }),
       commonjs(),
       typescript({
-        tsconfig: './tsconfig.json',
+        tsconfig: './tsconfig.build.json',
       }),
       postcss({
         modules: {

src/AuthProvider.tsx

@@ -5,6 +5,7 @@
  */
 
 import { InternalAuthProvider } from '@/context/InternalAuthContext';
+import { startAuthentication } from '@simplewebauthn/browser';
 import React, {
   createContext,
   ReactNode,
@@ -47,6 +48,8 @@ export interface AuthContextType {
   credentials: Credential[];
   updateCredential: (credential: Credential) => Promise<Credential>;
   deleteCredential: (credentialId: string) => Promise<void>;
+  login: (identifier: string, passkeyAvailable: boolean) => Promise<Response>;
+  handlePasskeyLogin: () => Promise<boolean>;
   loading: boolean;
 }
 
@@ -103,6 +106,54 @@ export const AuthProvider: React.FC<AuthProviderProps> = ({
     authHost: apiHost,
   });
 
+  const login = async (
+    identifier: string,
+    passkeyAvailable: boolean
+  ): Promise<Response> => {
+    const response = await fetchWithAuth(`/login`, {
+      method: 'POST',
+      body: JSON.stringify({ identifier, passkeyAvailable }),
+    });
+
+    return response;
+  };
+
+  const handlePasskeyLogin = async () => {
+    try {
+      const response = await fetchWithAuth(`/webAuthn/login/start`, {
+        method: 'POST',
+      });
+
+      const options = await response.json();
+      const credential = await startAuthentication({ optionsJSON: options });
+
+      const verificationResponse = await fetchWithAuth(`/webAuthn/login/finish`, {
+        method: 'POST',
+        body: JSON.stringify({ assertionResponse: credential }),
+      });
+
+      if (!verificationResponse.ok) {
+        console.error('Failed to verify passkey');
+      }
+
+      const verificationResult = await verificationResponse.json();
+
+      if (verificationResult.message === 'Success') {
+        if (verificationResult.mfaLogin) {
+          return true;
+        }
+        await validateToken();
+        return false;
+      } else {
+        console.error('Passkey login failed:', verificationResult.message);
+        return false;
+      }
+    } catch (error) {
+      console.error('Passkey login error:', error);
+      return false;
+    }
+  };
+
   const logout = useCallback(async () => {
     if (user) {
       try {
@@ -221,6 +272,8 @@ export const AuthProvider: React.FC<AuthProviderProps> = ({
         credentials,
         updateCredential,
         deleteCredential,
+        login,
+        handlePasskeyLogin,
       }}
     >
       <InternalAuthProvider value={{ validateToken, setLoading }}>

src/AuthRoutes.tsx

@@ -22,7 +22,7 @@ export const AuthRoutes = () => (
     <Route path="/verifyEmailOTP" element={<EmailRegistration />} />
     <Route path="/verify-magiclink" element={<VerifyMagicLink />} />
     <Route path="/registerPasskey" element={<PasskeyRegistration />} />
-    <Route path="/magic-link-sent" element={<MagicLinkSent />} />
+    <Route path="/magiclinks-sent" element={<MagicLinkSent />} />
     <Route path="*" element={<Navigate to="/login" replace />} />
   </Routes>
 );

src/utils.ts

@@ -5,7 +5,6 @@
  */
 
 import parsePhoneNumberFromString from 'libphonenumber-js';
-
 /**
  * isValidEmail
  *

src/views/Login.tsx

@@ -4,22 +4,24 @@
  * See LICENSE file in the project root for full license information
  */
 
-import { startAuthentication } from '@simplewebauthn/browser';
 import { useAuth } from '@/AuthProvider';
 import PhoneInputWithCountryCode from '@/components/phoneInput';
-import { useInternalAuth } from '@/context/InternalAuthContext';
 import React, { useEffect, useState } from 'react';
 import { useNavigate } from 'react-router-dom';
-
 import styles from '@/styles/login.module.css';
 import { isPasskeySupported, isValidEmail, isValidPhoneNumber } from '../utils';
 import { createFetchWithAuth } from '@/fetchWithAuth';
 import AuthFallbackOptions from '@/components/AuthFallbackOptions';
 
 const Login: React.FC = () => {
   const navigate = useNavigate();
-  const { apiHost, hasSignedInBefore, mode: authMode } = useAuth();
-  const { validateToken } = useInternalAuth();
+  const {
+    apiHost,
+    hasSignedInBefore,
+    mode: authMode,
+    login,
+    handlePasskeyLogin,
+  } = useAuth();
   const [identifier, setIdentifier] = useState<string>('');
   const [email, setEmail] = useState<string>('');
   const [mode, setMode] = useState<'login' | 'register'>('register');
@@ -76,73 +78,6 @@ const Login: React.FC = () => {
     return isValidEmail(email) && isValidPhoneNumber(phone);
   };
 
-  const handlePasskeyLogin = async () => {
-    try {
-      const response = await fetchWithAuth(`/webAuthn/login/start`, {
-        method: 'POST',
-      });
-
-      if (!response.ok) {
-        console.error('Something went wrong getting webauthn options');
-        return;
-      }
-
-      const options = await response.json();
-      const credential = await startAuthentication({ optionsJSON: options });
-
-      const verificationResponse = await fetchWithAuth(`/webAuthn/login/finish`, {
-        method: 'POST',
-        body: JSON.stringify({ assertionResponse: credential }),
-      });
-
-      if (!verificationResponse.ok) {
-        console.error('Failed to verify passkey');
-      }
-
-      const verificationResult = await verificationResponse.json();
-
-      if (verificationResult.message === 'Success') {
-        if (verificationResult.mfaLogin) {
-          navigate('/mfaLogin');
-          return;
-        }
-        await validateToken();
-        navigate('/');
-        return;
-      } else {
-        console.error('Passkey login failed:', verificationResult.message);
-      }
-    } catch (error) {
-      console.error('Passkey login error:', error);
-    }
-  };
-
-  const login = async () => {
-    setFormErrors('');
-
-    const response = await fetchWithAuth(`/login`, {
-      method: 'POST',
-      body: JSON.stringify({ identifier, passkeyAvailable }),
-    });
-
-    if (!response.ok) {
-      setFormErrors('Failed to send login link. Please try again.');
-      return;
-    }
-
-    if (!passkeyAvailable) {
-      setShowFallbackOptions(true);
-      return;
-    }
-
-    try {
-      await handlePasskeyLogin();
-    } catch (err) {
-      console.error('Passkey login failed', err);
-      setShowFallbackOptions(true);
-    }
-  };
-
   const register = async () => {
     setFormErrors('');
 
@@ -188,7 +123,7 @@ const Login: React.FC = () => {
         return;
       }
 
-      navigate('/magic-link-sent');
+      navigate('/magiclinks-sent');
     } catch (err) {
       console.error(err);
       setFormErrors('Failed to send magic link.');
@@ -217,7 +152,18 @@ const Login: React.FC = () => {
   const handleSubmit = async (e: React.FormEvent<HTMLFormElement>) => {
     e.preventDefault();
 
-    if (mode === 'login') login();
+    if (mode === 'login') {
+      const loginRes = await login(identifier, passkeyAvailable);
+
+      if (loginRes.ok && passkeyAvailable) {
+        const passkeyResult = await handlePasskeyLogin();
+        if (passkeyResult) {
+          navigate('/');
+        }
+      } else {
+        setShowFallbackOptions(true);
+      }
+    }
     if (mode === 'register') register();
   };
 

src/views/VerifyMagicLink.tsx

@@ -27,17 +27,21 @@ const VerifyMagicLink: React.FC = () => {
 
   useEffect(() => {
     const verify = async () => {
-      const response = await fetchWithAuth(`/magic-link/verify/${token}`, {
-        method: 'GET',
-        headers: {
-          'Content-Type': 'application/json',
-        },
-      });
-
-      if (!response.ok) {
-        console.error('Failed to verify token');
-        setError('Failed to verify token');
-        return;
+      try {
+        const response = await fetchWithAuth(`/magic-link/verify/${token}`, {
+          method: 'GET',
+          headers: {
+            'Content-Type': 'application/json',
+          },
+        });
+
+        if (!response.ok) {
+          console.error('Failed to verify token');
+          setError('Failed to verify token');
+          return;
+        }
+      } catch (error) {
+        console.error(error);
       }
 
       const channel = new BroadcastChannel('seamless-auth');

tests/AuthFallbackOptions.test.tsx

@@ -1,3 +1,9 @@
+/*
+ * Copyright © 2026 Fells Code, LLC
+ * Licensed under the GNU Affero General Public License v3.0
+ * See LICENSE file in the project root for full license information
+ */
+
 import { render, screen, fireEvent } from '@testing-library/react';
 import AuthFallbackOptions from '@/components/AuthFallbackOptions';
 

tests/AuthRoutes.test.tsx

@@ -1,3 +1,9 @@
+/*
+ * Copyright © 2026 Fells Code, LLC
+ * Licensed under the GNU Affero General Public License v3.0
+ * See LICENSE file in the project root for full license information
+ */
+
 import { MemoryRouter } from 'react-router-dom';
 import { render, screen } from '@testing-library/react';
 import { AuthRoutes } from '../src/AuthRoutes';

tests/DeviceModal.test.tsx

@@ -1,3 +1,9 @@
+/*
+ * Copyright © 2026 Fells Code, LLC
+ * Licensed under the GNU Affero General Public License v3.0
+ * See LICENSE file in the project root for full license information
+ */
+
 import { render, screen, fireEvent } from '@testing-library/react';
 import DeviceNameModal from '@/components/DeviceNameModal';