Bug: Git repos aren't fetched for changes

[Josh65-2201]

Description

Opening a git repo always shows there are no changes in the status bar. This has only started in 4.2.0.0 as far as I remember

Steps To Reproduce

1. Clone repo
2. Make changes to cloned repo externally
3. Open repo folder in Files
4. See status bar shows 0 incoming

Files Version

4.2.0.0

Windows Version

10.0.26200.8655

User ID

670e1391-905a-4fe8-a9da-a22f01a4676c

Log File

debug.log

[yair100]

@Lamparter can you please investigate?

[Lamparter]

@Josh65-2201 either I don't understand the issue or I can't reproduce it. You need to create a commit object for the app to show 1+ outgoing, or create a commit online on the remote for the app to show 1+ incoming.

having just created a commit on a test repo

[yair100]

The issue appears to be for incoming commits.

[Lamparter]

I was able to reproduce the issue even when I went as far as all the way back to v4.0.0.0 (before any changes to the Git functionality were introduced by me), so it's probably gone un-noticed for some time.

[Lamparter]

It appears the issue is inconsistent

[Josh65-2201]

It does normally take about 5-10 seconds before it shows. I have only seen it with incoming and have waited a few minutes on the Files repo but it doesn't change in VS it does after fetching.

[Lamparter]

It may simply be an issue with the way that LibGit2Sharp loads branch metadata (lazily). I investigated the code responsible for that part of the status bar and there is no apparent issue that would prevent this feature from working.

[Lamparter]

I'll admit that the Git integration is a bit fragile though

[yair100]

Can you check if the changes in ya/Git resolve this issue?

[Lamparter]

Yes, the issue is fixed on your branch! If you open a PR I can approve it