Skip to content

Commit 45d46bf

Browse files
lahirumarambalahirumaramba
committed
style: resolve checkstyle line length constraints across source and test files
1 parent 99c58c7 commit 45d46bf

5 files changed

Lines changed: 152 additions & 99 deletions

File tree

‎src/main/java/com/google/firebase/phonenumberverification/FirebasePhoneNumberVerification.java‎

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,27 @@ private FirebasePhoneNumberVerification(FirebaseApp app) {
3838
/**
3939
* Gets the {@link FirebasePhoneNumberVerification} instance for the default {@link FirebaseApp}.
4040
*
41-
* @return The {@link FirebasePhoneNumberVerification} instance for the default {@link FirebaseApp}.
41+
* @return The {@link FirebasePhoneNumberVerification} instance for the default
42+
* {@link FirebaseApp}.
4243
*/
4344
public static FirebasePhoneNumberVerification getInstance() {
4445
return getInstance(FirebaseApp.getInstance());
4546
}
4647

4748
/**
48-
* Gets the {@link FirebasePhoneNumberVerification} instance for the specified {@link FirebaseApp}.
49+
* Gets the {@link FirebasePhoneNumberVerification} instance for the specified
50+
* {@link FirebaseApp}.
4951
*
50-
* @return The {@link FirebasePhoneNumberVerification} instance for the specified {@link FirebaseApp}.
52+
* @return The {@link FirebasePhoneNumberVerification} instance for the specified
53+
* {@link FirebaseApp}.
5154
*/
5255
public static synchronized FirebasePhoneNumberVerification getInstance(FirebaseApp app) {
53-
FirebasePhoneNumberVerificationService service = ImplFirebaseTrampolines.getService(app, SERVICE_ID,
54-
FirebasePhoneNumberVerificationService.class);
56+
FirebasePhoneNumberVerificationService service =
57+
ImplFirebaseTrampolines.getService(app, SERVICE_ID,
58+
FirebasePhoneNumberVerificationService.class);
5559
if (service == null) {
56-
service = ImplFirebaseTrampolines.addService(app, new FirebasePhoneNumberVerificationService(app));
60+
service = ImplFirebaseTrampolines.addService(
61+
app, new FirebasePhoneNumberVerificationService(app));
5762
}
5863
return service.getInstance();
5964
}

‎src/main/java/com/google/firebase/phonenumberverification/FirebasePhoneNumberVerificationException.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ public FirebasePhoneNumberVerificationException(
4444
}
4545

4646
/**
47-
* Exception that created from {@link FirebasePhoneNumberVerificationErrorCode} and {@link String} message.
47+
* Exception that created from {@link FirebasePhoneNumberVerificationErrorCode}
48+
* and {@link String} message.
4849
*
4950
* @param errorCode {@link FirebasePhoneNumberVerificationErrorCode}
5051
* @param message {@link String}

‎src/test/java/com/google/firebase/phonenumberverification/FirebasePhoneNumberVerificationTest.java‎

Lines changed: 43 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -84,63 +84,77 @@ public void testGetInstanceForApp() {
8484
}
8585

8686
@Test
87-
public void testVerifyToken_DelegatesToVerifier() throws FirebasePhoneNumberVerificationException {
87+
public void testVerifyToken_DelegatesToVerifier()
88+
throws FirebasePhoneNumberVerificationException {
8889
String testToken = "test.token";
89-
FirebasePhoneNumberVerificationToken expectedToken = mock(FirebasePhoneNumberVerificationToken.class);
90+
FirebasePhoneNumberVerificationToken expectedToken =
91+
mock(FirebasePhoneNumberVerificationToken.class);
9092

9193
when(mockVerifier.verifyToken(testToken)).thenReturn(expectedToken);
9294

93-
FirebasePhoneNumberVerificationToken result = firebasePhoneNumberVerification.verifyToken(testToken);
95+
FirebasePhoneNumberVerificationToken result =
96+
firebasePhoneNumberVerification.verifyToken(testToken);
9497

9598
assertEquals(expectedToken, result);
9699
verify(mockVerifier, times(1)).verifyToken(testToken);
97100
}
98101

99102
@Test
100-
public void testVerifyToken_PropagatesException() throws FirebasePhoneNumberVerificationException {
103+
public void testVerifyToken_PropagatesException()
104+
throws FirebasePhoneNumberVerificationException {
101105
String testToken = "bad.token";
102-
FirebasePhoneNumberVerificationException error = new FirebasePhoneNumberVerificationException(
103-
FirebasePhoneNumberVerificationErrorCode.INVALID_TOKEN,
104-
"Bad token"
105-
);
106+
FirebasePhoneNumberVerificationException error =
107+
new FirebasePhoneNumberVerificationException(
108+
FirebasePhoneNumberVerificationErrorCode.INVALID_TOKEN,
109+
"Bad token"
110+
);
106111

107112
when(mockVerifier.verifyToken(testToken)).thenThrow(error);
108113

109-
FirebasePhoneNumberVerificationException e = assertThrows(FirebasePhoneNumberVerificationException.class, () ->
110-
FirebasePhoneNumberVerification.getInstance().verifyToken(testToken)
111-
);
112-
assertEquals(FirebasePhoneNumberVerificationErrorCode.INVALID_TOKEN, e.getPhoneNumberVerificationErrorCode());
114+
FirebasePhoneNumberVerificationException e =
115+
assertThrows(FirebasePhoneNumberVerificationException.class, () ->
116+
FirebasePhoneNumberVerification.getInstance().verifyToken(testToken)
117+
);
118+
assertEquals(FirebasePhoneNumberVerificationErrorCode.INVALID_TOKEN,
119+
e.getPhoneNumberVerificationErrorCode());
113120
}
114121

115122
@Test
116-
public void testVerifyToken_PropagatesException_Service_Error() throws FirebasePhoneNumberVerificationException {
123+
public void testVerifyToken_PropagatesException_Service_Error()
124+
throws FirebasePhoneNumberVerificationException {
117125
String testToken = "SERVICE_ERROR";
118-
FirebasePhoneNumberVerificationException error = new FirebasePhoneNumberVerificationException(
119-
FirebasePhoneNumberVerificationErrorCode.SERVICE_ERROR,
120-
"SERVICE_ERROR"
121-
);
126+
FirebasePhoneNumberVerificationException error =
127+
new FirebasePhoneNumberVerificationException(
128+
FirebasePhoneNumberVerificationErrorCode.SERVICE_ERROR,
129+
"SERVICE_ERROR"
130+
);
122131

123132
when(mockVerifier.verifyToken(testToken)).thenThrow(error);
124133

125-
FirebasePhoneNumberVerificationException e = assertThrows(FirebasePhoneNumberVerificationException.class, () ->
126-
FirebasePhoneNumberVerification.getInstance().verifyToken(testToken)
127-
);
128-
assertEquals(FirebasePhoneNumberVerificationErrorCode.SERVICE_ERROR, e.getPhoneNumberVerificationErrorCode());
134+
FirebasePhoneNumberVerificationException e =
135+
assertThrows(FirebasePhoneNumberVerificationException.class, () ->
136+
FirebasePhoneNumberVerification.getInstance().verifyToken(testToken)
137+
);
138+
assertEquals(FirebasePhoneNumberVerificationErrorCode.SERVICE_ERROR,
139+
e.getPhoneNumberVerificationErrorCode());
129140
}
130141

131142
@Test
132-
public void testVerifyToken_PropagatesException_Internal_Error() throws FirebasePhoneNumberVerificationException {
143+
public void testVerifyToken_PropagatesException_Internal_Error()
144+
throws FirebasePhoneNumberVerificationException {
133145
String testToken = "INTERNAL";
134-
FirebasePhoneNumberVerificationException error = new FirebasePhoneNumberVerificationException(
135-
null,
136-
"INTERNAL"
137-
);
146+
FirebasePhoneNumberVerificationException error =
147+
new FirebasePhoneNumberVerificationException(
148+
null,
149+
"INTERNAL"
150+
);
138151

139152
when(mockVerifier.verifyToken(testToken)).thenThrow(error);
140153

141-
FirebasePhoneNumberVerificationException e = assertThrows(FirebasePhoneNumberVerificationException.class, () ->
142-
FirebasePhoneNumberVerification.getInstance().verifyToken(testToken)
143-
);
154+
FirebasePhoneNumberVerificationException e =
155+
assertThrows(FirebasePhoneNumberVerificationException.class, () ->
156+
FirebasePhoneNumberVerification.getInstance().verifyToken(testToken)
157+
);
144158
assertNull(e.getPhoneNumberVerificationErrorCode());
145159
}
146160
}

‎src/test/java/com/google/firebase/phonenumberverification/FirebasePhoneNumberVerificationTokenTest.java‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ public void test_Audience_Empty() {
5050
.expirationTime(new Date(System.currentTimeMillis() + 10000))
5151
.build();
5252

53-
FirebasePhoneNumberVerificationToken token = new FirebasePhoneNumberVerificationToken(claims.getClaims());
53+
FirebasePhoneNumberVerificationToken token =
54+
new FirebasePhoneNumberVerificationToken(claims.getClaims());
5455

5556
assertNotNull(token);
5657
assertEquals(ImmutableList.of(), token.getAudience());
@@ -65,7 +66,8 @@ public void test_Audience_List() {
6566
.expirationTime(new Date(System.currentTimeMillis() + 10000))
6667
.build();
6768

68-
FirebasePhoneNumberVerificationToken token = new FirebasePhoneNumberVerificationToken(claims.getClaims());
69+
FirebasePhoneNumberVerificationToken token =
70+
new FirebasePhoneNumberVerificationToken(claims.getClaims());
6971

7072
assertNotNull(token);
7173
assertEquals(ImmutableList.of(), token.getAudience());

0 commit comments

Comments
 (0)