fix(remoteconfig): catch parsing runtime exceptions in fromJSON to stabilize headless pipelines

Author: lahirumaramba

src/main/java/com/google/firebase/remoteconfig/ServerTemplateData.java

@@ -93,9 +93,9 @@ static ServerTemplateData fromJSON(@NonNull String json)
       ServerTemplateResponse serverTemplateResponse =
           jsonFactory.createJsonParser(json).parseAndClose(ServerTemplateResponse.class);
       return new ServerTemplateData(serverTemplateResponse);
-    } catch (IOException e) {
+    } catch (Exception e) {
       throw new FirebaseRemoteConfigException(
-          ErrorCode.INVALID_ARGUMENT, "Unable to parse JSON string.");
+          ErrorCode.INVALID_ARGUMENT, "Unable to parse JSON string.", e);
     }
   }
 

src/main/java/com/google/firebase/remoteconfig/Template.java

@@ -106,9 +106,9 @@ public static Template fromJSON(@NonNull String json) throws FirebaseRemoteConfi
       TemplateResponse templateResponse = jsonFactory.createJsonParser(json)
               .parseAndClose(TemplateResponse.class);
       return new Template(templateResponse);
-    } catch (IOException e) {
-      throw new FirebaseRemoteConfigException(ErrorCode.INVALID_ARGUMENT,
-              "Unable to parse JSON string.");
+    } catch (Exception e) {
+      throw new FirebaseRemoteConfigException(
+          ErrorCode.INVALID_ARGUMENT, "Unable to parse JSON string.", e);
     }
   }
 

src/test/java/com/google/firebase/phonenumberverification/internal/FirebasePhoneNumberVerificationTokenVerifierTest.java

@@ -431,7 +431,8 @@ public void testVerifyToken_EmptyProjectId() {
         + "  \"auth_uri\": \"https://accounts.google.com/o/oauth2/auth\",\n"
         + "  \"token_uri\": \"https://accounts.google.com/o/oauth2/token\",\n"
         + "  \"auth_provider_x509_cert_url\": \"https://www.googleapis.com/oauth2/v1/certs\",\n"
-        + "  \"client_x509_cert_url\": \"https://www.googleapis.com/robot/v1/metadata/x509/mock-project-id-none%40mock-project-id.iam.gserviceaccount.com\"\n"
+        + "  \"client_x509_cert_url\": \"https://www.googleapis.com/robot/v1/metadata/x509/"
+        + "mock-project-id-none%40mock-project-id.iam.gserviceaccount.com\"\n"
         + "}";
 
     FirebaseOptions localFirebaseOptions = FirebaseOptions.builder()