Skip to content

Commit 0509f0a

Browse files
committed
Position tokens first to guarantee backward compatibility for legacy positional arguments and add a unit test for it
1 parent f384d6e commit 0509f0a

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

firebase_admin/_messaging_encoder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ class MulticastMessage:
8484
fcm_options: An instance of ``messaging.FCMOptions`` (optional).
8585
"""
8686
def __init__(
87-
self, fids=None, tokens=None, data=None, notification=None, android=None,
87+
self, tokens=None, fids=None, data=None, notification=None, android=None,
8888
webpush=None, apns=None, fcm_options=None):
8989
if tokens is not None:
9090
warnings.warn(

tests/test_messaging.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,10 @@ def test_tokens_deprecation_warning(self):
160160
with pytest.deprecated_call():
161161
messaging.MulticastMessage(tokens=['token'])
162162

163+
def test_tokens_deprecation_warning_positional(self):
164+
with pytest.deprecated_call():
165+
messaging.MulticastMessage(['token'])
166+
163167

164168
class TestMessageEncoder:
165169

0 commit comments

Comments
 (0)