Skip to content

Commit 1ff0f98

Browse files
authored
SDK Deprecation message Authentication (#42)
* add deprecation warning field * sdk deprecation structure * lint
1 parent 380868a commit 1ff0f98

3 files changed

Lines changed: 75 additions & 0 deletions

File tree

doc/docs.md

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,10 @@
8080
- [PeerMessage.Authenticated](#fishjam-PeerMessage-Authenticated)
8181
- [PeerMessage.MediaEvent](#fishjam-PeerMessage-MediaEvent)
8282
- [PeerMessage.RTCStatsReport](#fishjam-PeerMessage-RTCStatsReport)
83+
- [PeerMessage.SdkDeprecation](#fishjam-PeerMessage-SdkDeprecation)
8384

8485
- [PeerMessage.RoomType](#fishjam-PeerMessage-RoomType)
86+
- [PeerMessage.SdkDeprecation.Status](#fishjam-PeerMessage-SdkDeprecation-Status)
8587

8688
- [fishjam/server_notifications.proto](#fishjam_server_notifications-proto)
8789
- [ServerMessage](#fishjam-ServerMessage)
@@ -1190,6 +1192,7 @@ Response sent by FJ, confirming successful authentication
11901192
| Field | Type | Label | Description |
11911193
| ----- | ---- | ----- | ----------- |
11921194
| room_type | [PeerMessage.RoomType](#fishjam-PeerMessage-RoomType) | | |
1195+
| sdk_deprecation | [PeerMessage.SdkDeprecation](#fishjam-PeerMessage-SdkDeprecation) | | |
11931196

11941197

11951198

@@ -1226,6 +1229,22 @@ https://developer.mozilla.org/en-US/docs/Web/API/RTCStatsReport#the_statistic_ty
12261229

12271230

12281231

1232+
1233+
<a name="fishjam-PeerMessage-SdkDeprecation"></a>
1234+
1235+
### PeerMessage.SdkDeprecation
1236+
Deprecation status for SDK version
1237+
1238+
1239+
| Field | Type | Label | Description |
1240+
| ----- | ---- | ----- | ----------- |
1241+
| status | [PeerMessage.SdkDeprecation.Status](#fishjam-PeerMessage-SdkDeprecation-Status) | | |
1242+
| message | [string](#string) | | |
1243+
1244+
1245+
1246+
1247+
12291248

12301249

12311250

@@ -1242,6 +1261,20 @@ Defines types of rooms peers may connect to
12421261
| ROOM_TYPE_LIVESTREAM | 3 | |
12431262

12441263

1264+
1265+
<a name="fishjam-PeerMessage-SdkDeprecation-Status"></a>
1266+
1267+
### PeerMessage.SdkDeprecation.Status
1268+
1269+
1270+
| Name | Number | Description |
1271+
| ---- | ------ | ----------- |
1272+
| STATUS_UNSPECIFIED | 0 | |
1273+
| STATUS_UP_TO_DATE | 1 | |
1274+
| STATUS_DEPRECATED | 2 | |
1275+
| STATUS_UNSUPPORTED | 3 | |
1276+
1277+
12451278

12461279

12471280

fishjam/peer_notifications.proto

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,23 @@ message PeerMessage {
1515
ROOM_TYPE_LIVESTREAM = 3;
1616
}
1717

18+
// Deprecation status for SDK version
19+
message SdkDeprecation {
20+
enum Status {
21+
STATUS_UNSPECIFIED = 0;
22+
STATUS_UP_TO_DATE = 1;
23+
STATUS_DEPRECATED = 2;
24+
STATUS_UNSUPPORTED = 3;
25+
}
26+
27+
Status status = 1;
28+
string message = 2;
29+
}
30+
1831
// Response sent by FJ, confirming successful authentication
1932
message Authenticated {
2033
RoomType room_type = 1;
34+
SdkDeprecation sdk_deprecation = 2;
2135
}
2236

2337
// Request sent by peer, to authenticate to FJ server

fishjam_protos/lib/fishjam/peer_notifications.pb.ex

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,33 @@ defmodule Fishjam.PeerMessage.RoomType do
1313
field :ROOM_TYPE_LIVESTREAM, 3
1414
end
1515

16+
defmodule Fishjam.PeerMessage.SdkDeprecation.Status do
17+
@moduledoc false
18+
19+
use Protobuf,
20+
enum: true,
21+
full_name: "fishjam.PeerMessage.SdkDeprecation.Status",
22+
protoc_gen_elixir_version: "0.16.0",
23+
syntax: :proto3
24+
25+
field :STATUS_UNSPECIFIED, 0
26+
field :STATUS_UP_TO_DATE, 1
27+
field :STATUS_DEPRECATED, 2
28+
field :STATUS_UNSUPPORTED, 3
29+
end
30+
31+
defmodule Fishjam.PeerMessage.SdkDeprecation do
32+
@moduledoc false
33+
34+
use Protobuf,
35+
full_name: "fishjam.PeerMessage.SdkDeprecation",
36+
protoc_gen_elixir_version: "0.16.0",
37+
syntax: :proto3
38+
39+
field :status, 1, type: Fishjam.PeerMessage.SdkDeprecation.Status, enum: true
40+
field :message, 2, type: :string
41+
end
42+
1643
defmodule Fishjam.PeerMessage.Authenticated do
1744
@moduledoc false
1845

@@ -22,6 +49,7 @@ defmodule Fishjam.PeerMessage.Authenticated do
2249
syntax: :proto3
2350

2451
field :room_type, 1, type: Fishjam.PeerMessage.RoomType, json_name: "roomType", enum: true
52+
field :sdk_deprecation, 2, type: Fishjam.PeerMessage.SdkDeprecation, json_name: "sdkDeprecation"
2553
end
2654

2755
defmodule Fishjam.PeerMessage.AuthRequest do

0 commit comments

Comments
 (0)