From 9e73a79f30a68c252ad923c21bd50533dd781bb0 Mon Sep 17 00:00:00 2001 From: Bernard Gawor Date: Wed, 25 Mar 2026 12:35:59 +0100 Subject: [PATCH 1/3] remove "or echo" part from typecheck --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index c36f69c1..36147c6c 100644 --- a/package.json +++ b/package.json @@ -22,7 +22,7 @@ "test:unit": "yarn workspaces foreach -Ap run test", "test:e2e": "yarn workspaces foreach -A --include '@fishjam-e2e/*' run e2e", "gen:proto": "yarn workspace @fishjam-cloud/protobufs gen:proto", - "tsc": "yarn workspaces foreach -Ap run tsc || echo '❌ Type errors! ❌' ", + "tsc": "yarn workspaces foreach -Ap run tsc", "format:root": "prettier . --write", "format:root:check": "prettier . --check", "format": "yarn format:root & yarn workspaces foreach -A -p run format || echo '❌ Formatting issues! ❌'", From 6470d81022463b39b50d3eab6ea5b8023617d68e Mon Sep 17 00:00:00 2001 From: Bernard Gawor Date: Wed, 25 Mar 2026 12:48:48 +0100 Subject: [PATCH 2/3] test if only tsc fails --- packages/ts-client/package.json | 3 ++- packages/ts-client/src/version.ts | 2 +- packages/ts-client/tsconfig.json | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/ts-client/package.json b/packages/ts-client/package.json index 7abde636..ab66f7cd 100644 --- a/packages/ts-client/package.json +++ b/packages/ts-client/package.json @@ -34,8 +34,9 @@ "dist/**" ], "scripts": { - "build": "yarn build:check && tsup", + "build": "tsup", "build:check": "tsc --noEmit", + "tsc": "tsc --noEmit", "format": "prettier --write . --ignore-path ./.eslintignore", "format:check": "prettier --check . --ignore-path ./.eslintignore", "lint": "eslint . --ext .ts,.tsx --fix", diff --git a/packages/ts-client/src/version.ts b/packages/ts-client/src/version.ts index 85d6e4a2..4a801aa2 100644 --- a/packages/ts-client/src/version.ts +++ b/packages/ts-client/src/version.ts @@ -1,3 +1,3 @@ import { version } from '../package.json'; -export const packageVersion = version; +export const packageVersion: number = version; diff --git a/packages/ts-client/tsconfig.json b/packages/ts-client/tsconfig.json index 07ba7bba..e6d1f5f9 100644 --- a/packages/ts-client/tsconfig.json +++ b/packages/ts-client/tsconfig.json @@ -10,6 +10,7 @@ "skipLibCheck": true, "esModuleInterop": true, "declaration": true, + "resolveJsonModule": true, "forceConsistentCasingInFileNames": true, "noFallthroughCasesInSwitch": true, From cbf3cfc4b7918ced865567a0c1b60a59805e1ae4 Mon Sep 17 00:00:00 2001 From: Bernard Gawor Date: Wed, 25 Mar 2026 12:51:55 +0100 Subject: [PATCH 3/3] Revert "test if only tsc fails" This reverts commit 6470d81022463b39b50d3eab6ea5b8023617d68e. --- packages/ts-client/package.json | 3 +-- packages/ts-client/src/version.ts | 2 +- packages/ts-client/tsconfig.json | 1 - 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/ts-client/package.json b/packages/ts-client/package.json index ab66f7cd..7abde636 100644 --- a/packages/ts-client/package.json +++ b/packages/ts-client/package.json @@ -34,9 +34,8 @@ "dist/**" ], "scripts": { - "build": "tsup", + "build": "yarn build:check && tsup", "build:check": "tsc --noEmit", - "tsc": "tsc --noEmit", "format": "prettier --write . --ignore-path ./.eslintignore", "format:check": "prettier --check . --ignore-path ./.eslintignore", "lint": "eslint . --ext .ts,.tsx --fix", diff --git a/packages/ts-client/src/version.ts b/packages/ts-client/src/version.ts index 4a801aa2..85d6e4a2 100644 --- a/packages/ts-client/src/version.ts +++ b/packages/ts-client/src/version.ts @@ -1,3 +1,3 @@ import { version } from '../package.json'; -export const packageVersion: number = version; +export const packageVersion = version; diff --git a/packages/ts-client/tsconfig.json b/packages/ts-client/tsconfig.json index e6d1f5f9..07ba7bba 100644 --- a/packages/ts-client/tsconfig.json +++ b/packages/ts-client/tsconfig.json @@ -10,7 +10,6 @@ "skipLibCheck": true, "esModuleInterop": true, "declaration": true, - "resolveJsonModule": true, "forceConsistentCasingInFileNames": true, "noFallthroughCasesInSwitch": true,