Skip to content

Commit 17352ff

Browse files
committed
Run dcm unused-code check over devtools_shared
1 parent d6079ca commit 17352ff

3 files changed

Lines changed: 2 additions & 7 deletions

File tree

.github/workflows/build.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ jobs:
8686
- name: Run dcm checks on packages
8787
# TODO(https://github.com/flutter/devtools/issues/9906): run on all DevTools packages.
8888
run: |
89-
dcm check-unused-code packages/devtools_app --exclude-public-api
89+
dcm check-unused-code packages/devtools_app packages/devtools_shared --exclude-public-api
9090
9191
test-packages:
9292
name: ${{ matrix.os }} ${{ matrix.package }} test

packages/devtools_shared/lib/src/server/flutter_store.dart

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,10 @@ import 'file_system.dart';
77
/// Provides access to the local Flutter store (~/.flutter).
88
class FlutterStore {
99
static const storeName = '.flutter';
10-
static const firstRunKey = 'firstRun';
11-
static const gaEnabledKey = 'enabled';
1210
static const flutterClientIdKey = 'clientId';
1311

1412
final properties = IOPersistentProperties(storeName);
1513

16-
bool get isFirstRun => properties[firstRunKey] == true;
17-
18-
bool get gaEnabled => properties[gaEnabledKey] == true;
19-
2014
String get flutterClientId =>
2115
(properties[flutterClientIdKey] as String?) ?? '';
2216
}

packages/devtools_shared/lib/src/utils/file_utils.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import 'package:dtd/dtd.dart';
66
import 'package:meta/meta.dart';
77

8+
// ignore: unused-code, false positive.
89
const _fileUriPrefix = 'file://';
910

1011
/// Attempts to detect the package root of [fileUriString], which is expected to

0 commit comments

Comments
 (0)