chore(vibe-risk): remediate findings to 91/100 (build green)#7
Merged
Conversation
Workflow-orchestrated remediation + manual cleanup. All legitimate vibe-risk findings resolved; 10/12 dimensions maxed; full build green. - fix: break preview-site circular dep (Nav -> route-loaders -> PlaygroundPage) via leaf nav-metrics.ts; 0 cycles across all 3 packages - refactor: split 13 god files, preserving public exports + import paths (Footer 8904->3734, builder 6527->1157, index 5787->1613, e2e 10953->2726, Toolbar/FileExplorer/Hero/ScreenContent/handlers/simulate-strip/ PlaygroundSection/ChangelogPage/apply-ui-snapshot/sync-ui-snapshots); files >4000 tokens: 20 -> 7 - chore: remove 4 unused deps (@radix-ui/react-label, @tanstack/react-query, clsx, tailwind-merge) + 6 orphan files (device-mockups, ThemeToggle); pnpm-lock.yaml synced - docs: expand root AGENTS.md 39->129 lines; add preview-site/.agent/rules - chore: record vibe-risk scan history (91/100 EXCELLENT) Verified: typecheck + 707 tests + lint (--max-warnings 0) + 0 madge cycles in all 3 packages; jscpd duplication 1.98%. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workflow-orchestrated remediation (21-agent fan-out) + manual cleanup of the vibe-risk-analyzer findings. All legitimate findings resolved, 10/12 dimensions maxed, full build green. Score 87 → 91/100 EXCELLENT; Refactoring Risk 16→10, AI Extension Risk 10→7 (both MINIMAL).
Changes
Nav → route-loaders → PlaygroundPageby relocatingNAV_REGION_HEIGHT_REMinto a dependency-free leafnav-metrics.ts. madge now reports 0 cycles in all 3 packages.Footer 8904→3734, builder 6527→1157, index 5787→1613, e2e 10953→2726, plus Toolbar / FileExplorer / Hero / ScreenContent / handlers / simulate-strip / PlaygroundSection / ChangelogPage / apply-ui-snapshot / sync-ui-snapshots. Files >4000 tokens: 20 → 7.
@radix-ui/react-label,@tanstack/react-query,clsx,tailwind-merge) + 6 orphan files (device-mockups/*,nav/ThemeToggle);pnpm-lock.yamlsynced.AGENTS.md39 → 129 lines (dev env, per-package conventions, the 12 structure scan tests, PR-NNN pointer, pitfalls); addpreview-site/.agent/rules/00-structure.md(PR-PV-001..005 fence).91/100 EXCELLENT).Verification
pnpm verify:fast— ALL PASSED:--max-warnings 0, 3 packagesScope note (not a perfect 100, by design)
The remaining gap is Module SRP (6/14) and Type Safety (11/12). Closing them to a literal 100 would require fragmenting ~60 cohesive files (i18n translation tables, icon-path data, UI showcases) below 1200 tokens and stripping ~125 legitimate
asassertions — both degrade maintainability. 91/EXCELLENT is the accepted healthy ceiling; no maintainability-damaging churn was made.🤖 Generated with Claude Code