chore: remove deprecated fs prop

Author: cristiand391

.sfdevrc.json

@@ -1,4 +1,5 @@
 {
+  "devDepOverrides": ["@types/node"],
   "wireit": {
     "compile": {
       "clean": "if-file-deleted",

package.json

@@ -49,6 +49,7 @@
     "@types/graceful-fs": "^4.1.9",
     "@types/mime": "2.0.3",
     "@types/minimatch": "^5.1.2",
+    "@types/node": "^20",
     "deep-equal-in-any-order": "^1.1.19",
     "esbuild": "^0.25.8",
     "eslint-plugin-sf-plugin": "^1.20.30",

test/registry/presetTesting.ts

@@ -23,7 +23,7 @@ const registriesFromPresets = fs
   .filter((file) => !file.name.endsWith('CustomLabelsBeta.json'))
   .map((file) => ({
     name: file.name,
-    registry: JSON.parse(fs.readFileSync(path.join(file.path, file.name), 'utf-8')) as MetadataRegistry,
+    registry: JSON.parse(fs.readFileSync(path.join(file.parentPath, file.name), 'utf-8')) as MetadataRegistry,
   })) /*
   decomposedPermissionSetBeta2 has an invalid registry configured.
   this is because multiple children will map to the .objectSettings suffix, and currently, the registry only supports 1:1 suffix mapping

test/snapshot/helper/conversions.ts

@@ -123,7 +123,7 @@ const resolveRelative = (parentDirs: string[]) => (subArray: string[], index: nu
 const getRelative = (parent: string) => (child: string) => path.relative(parent, child);
 
 const isFile = (file: fs.Dirent) => file.isFile();
-const getFullPath = (file: fs.Dirent) => path.join(file.path, file.name);
+const getFullPath = (file: fs.Dirent) => path.join(file.parentPath, file.name);
 
 /** dirEnts are sometimes folder, we don't want those.  And we need the full paths */
 export const dirEntsToPaths = (dirEnts: fs.Dirent[]): string[] => dirEnts.filter(isFile).map(getFullPath);

yarn.lock

@@ -1019,6 +1019,13 @@
   dependencies:
     undici-types "~5.26.4"
 
+"@types/node@^20":
+  version "20.19.11"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-20.19.11.tgz#728cab53092bd5f143beed7fbba7ba99de3c16c4"
+  integrity sha512-uug3FEEGv0r+jrecvUUpbY8lLisvIjg6AAic6a2bSP5OEOLeJsDSnvhCDov7ipFFMXS3orMpzlmi0ZcuGkBbow==
+  dependencies:
+    undici-types "~6.21.0"
+
 "@types/normalize-package-data@^2.4.0":
   version "2.4.1"
   resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.1.tgz#d3357479a0fdfdd5907fe67e17e0a85c906e1301"
@@ -5840,6 +5847,11 @@ undici-types@~5.26.4:
   resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-5.26.5.tgz#bcd539893d00b56e964fd2657a4866b221a65617"
   integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==
 
+undici-types@~6.21.0:
+  version "6.21.0"
+  resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-6.21.0.tgz#691d00af3909be93a7faa13be61b3a5b50ef12cb"
+  integrity sha512-iwDZqg0QAGrg9Rav5H4n0M64c3mkR59cJ6wQp+7C4nI0gsmExaedaYLNO44eT4AtBBwjbTiGPMlt2Md0T9H9JQ==
+
 universalify@^0.1.0:
   version "0.1.2"
   resolved "https://registry.yarnpkg.com/universalify/-/universalify-0.1.2.tgz#b646f69be3942dabcecc9d6639c80dc105efaa66"