[BUG] apple simply disappears

[agathaicmc]

Before creating a new issue
[X] I checked if there's already an issue or PR open for this
[X] I tested it in the latest commit on dev branch

Describe the bug
sometimes i'm playing the game normally, eat an apple, and the next apple doesn't spawn (or spawns off-screen, i couldnt say)

To Reproduce
in any game mode, eat some apples until they simply stop spawning

Expected behavior
apples should keep spawning until you beat the game

[gusvidigal]

Hello, I couldn't reproduce the bug. Can you specify how often the bug does occur? For example, at least once in a game, or it is very occasionally. Have you tried with more than one apple a time? What happens next? Consider changing some settings and see if it still happens. Those details may help identify the bug and fix it.

[agathaicmc]

i tried opening and reopening the game a couple times and realized the bug is actually kinda rare, and i have no idea what causes it, it is very occasionally. and no, i haven't tried it with more than one apple at a time.

when the apple disappears i'm just unable to keep playing, since there's no more apple my only option is to bash my head against the electric walls and die

[gusvidigal]

Could you send a video showing the bug?

[agathaicmc]

applegone.mp4

here, i was able to take a video of it happening! sorry for the noises of dogs barking and key pressing, i forgot to turn my mic off while recording

but i was able to recreate it in the latest version, it's kinda rare, but sometimes the apple just stops spawning after a while playing, though i don't know what could be causing this to happen '-'

[gustavorspires]

Hello! I tested now and I can affirm it is really a bug, but no idea where it happens

[BernaTameirao]

Sorry, I unpinned without realizing it!

[JeanJPNM]

This could be caused by the non-deterministic apple spawning algorithm, which has a 1000 attempt limit to find a spot for the new apple.

naja/src/ecs/systems/apple_spawn.py

Lines 140 to 166 in b4f747d

	occupied = self._get_occupied_positions(world)
	# Check if Cheese mode is enabled
	game_state_entities = world.registry.query_by_component("game_state")
	cheese_mode = False
	if game_state_entities:
	entity = next(iter(game_state_entities.values()))
	if hasattr(entity, "game_state"):
	cheese_mode = entity.game_state.cheese_mode_enabled
	# Try to find a valid position
	for _ in range(self._max_spawn_attempts):
	x = random.randint(0, board.width - 1)
	y = random.randint(0, board.height - 1)
	if (x, y) not in occupied:
	# In Cheese mode, require at least 2 empty neighbors
	if cheese_mode:
	empty_neighbors = self._count_empty_neighbors(x, y, board, occupied)
	if empty_neighbors < 2:
	continue # Try another position
	return (x, y)
	# If we couldn't find a position after max attempts, return None
	# This can happen in very cramped situations
	return None

[GiordanoSL]

During some tests when I was implementing something else I discovered that this may be happening due to another bug that I described on Issue #510. There seems to be an extra row on the bottom that is outside of the screen, the apple is spawning on this extra row and that is way you can't see it.

Here is a video where I eat the "invisible" apple.

snake.mp4