Handle browser.xul.error_pages.enabled (was: Not working on Firefox 26)

[Maelan]

This addon does not work on Firefox 26 (nor 28).

It has no effect at all, and modifications made to the whitelist in preferences are not taken into account. Here is the Javascript error I get in the error console when doing so:

 TypeError: sce.Debug is undefined    (in resource://sce/commons.js:43)

[Maelan]

PS: I have version 0.4.1 of this addon (just downloaded from Mozilla website).

[foudfou]

Thank you for reporting.
There was indeed a problem with logging that was fixed in e399aa0.
The extension is working for me in FF28 though.
I suggest you:

• clean preferences related to extensions.sce.* in prefs.js in your profile
• build from the sources: cd src ; make build after cloning this repo, and install from the built .xpi
  Tell how it goes.

[Maelan]

It did solve the bug with preferences, but the addon still has no effect for me: as a test I am trying to load https://progdupeu.pl which has a self-signed certificate; nothing particular seems to happen compared to the case the addon is absent, even if I add progdupeu.pl or .progdupeu.pl in the whitelist (the browser console is of no help this time).

[Maelan]

The problem seems OS-dependent, because I was on ArchLinux, and I just tested the addon successfully on Windows XP (Firefox 28 too). It seems that the two versions of Firefox handle an invalid certificate differently, which could explain the bug: on Windows it displays a frame inside the tab with detailed information (see image attached), when on ArchLinux it only gives a popup with the content of "Détails techniques" and with no opportunity to add an exception (basically why I wanted your addon, actually).

[foudfou]

Mmh. Testing on Arch with a clean profile, SkipErrorCert works fine on https://progdupeu.pl/... Do you get any messages in the JS console ?

[Maelan]

In fact, this was due to some strange values in my configuration. I had browser.xul.error_pages.enabled set to false. Setting it to true, I get the browser page which lets me add an exception. And in that condition SkipCertError does its job.

So the bug is now fixed for me, but is should be nice to make the addon handle that case in some way (perhaps simply by automatically setting the preference).

[Notice than there seems to be a bug when trying to register an exception permanently when it was previously added as temporary, then deleted:

< chrome//sce/content/overlay.js:152 >
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsICertOverrideService.rememberValidityOverride]

but apparently this is Firefox’s fault, since I get it from the standard dialog too (chrome//pippki/content/exceptionDialog.js:375).]