Skip to content
This repository was archived by the owner on Jan 7, 2026. It is now read-only.
This repository was archived by the owner on Jan 7, 2026. It is now read-only.

pylint the MakoCamera #10

@fretchen

Description

@fretchen

it keeps raising a few weird warnings.

pylint MakoCamera 
************* Module MakoCamera
MakoCamera/__init__.py:1:0: C0103: Module name "MakoCamera" doesn't conform to snake_case naming style (invalid-name)
************* Module MakoCamera.blacs_tabs
MakoCamera/blacs_tabs.py:17:0: W0223: Method 'start_run' is abstract in class 'DeviceTab' but is not overridden (abstract-method)
************* Module MakoCamera.blacs_workers
MakoCamera/blacs_workers.py:163:0: C0301: Line too long (143/100) (line-too-long)
MakoCamera/blacs_workers.py:193:30: C0303: Trailing whitespace (trailing-whitespace)
MakoCamera/blacs_workers.py:194:0: C0303: Trailing whitespace (trailing-whitespace)
MakoCamera/blacs_workers.py:195:70: C0303: Trailing whitespace (trailing-whitespace)
MakoCamera/blacs_workers.py:22:0: C0103: Constant name "Vimba" doesn't conform to UPPER_CASE naming style (invalid-name)
MakoCamera/blacs_workers.py:23:0: C0103: Constant name "VimbaException" doesn't conform to UPPER_CASE naming style (invalid-name)
MakoCamera/blacs_workers.py:26:0: C0103: Class name "Mako_Camera" doesn't conform to PascalCase naming style (invalid-name)
MakoCamera/blacs_workers.py:26:0: R0205: Class 'Mako_Camera' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
MakoCamera/blacs_workers.py:32:8: W0621: Redefining name 'Vimba' from outer scope (line 22) (redefined-outer-name)
MakoCamera/blacs_workers.py:32:8: W0621: Redefining name 'VimbaException' from outer scope (line 23) (redefined-outer-name)
MakoCamera/blacs_workers.py:30:8: W0603: Using the global statement (global-statement)
MakoCamera/blacs_workers.py:30:8: C0103: Constant name "Vimba" doesn't conform to UPPER_CASE naming style (invalid-name)
MakoCamera/blacs_workers.py:31:8: W0603: Using the global statement (global-statement)
MakoCamera/blacs_workers.py:31:8: C0103: Constant name "VimbaException" doesn't conform to UPPER_CASE naming style (invalid-name)
MakoCamera/blacs_workers.py:32:8: C0415: Import outside toplevel (pymba) (import-outside-toplevel)
MakoCamera/blacs_workers.py:58:8: W0702: No exception type(s) specified (bare-except)
MakoCamera/blacs_workers.py:63:29: W0613: Unused argument 'visibility_level' (unused-argument)
MakoCamera/blacs_workers.py:63:47: W0613: Unused argument 'writeable_only' (unused-argument)
MakoCamera/blacs_workers.py:107:12: W0201: Attribute 'frame' defined outside __init__ (attribute-defined-outside-init)
MakoCamera/blacs_workers.py:136:16: W0201: Attribute 'frame' defined outside __init__ (attribute-defined-outside-init)
MakoCamera/blacs_workers.py:167:12: W0201: Attribute 'frame' defined outside __init__ (attribute-defined-outside-init)
MakoCamera/blacs_workers.py:203:15: E1101: Instance of 'IMAQdx_Camera' has no 'get_attributes' member; maybe 'set_attributes'? (no-member)
MakoCamera/blacs_workers.py:203:15: E1101: Instance of 'MockCamera' has no 'get_attributes' member; maybe 'set_attributes'? (no-member)
************* Module MakoCamera.labscript_devices
MakoCamera/labscript_devices.py:17:0: C0103: Class name "Mako_Camera" doesn't conform to PascalCase naming style (invalid-name)

Can we get rid of the the globals as they seem a bit sketchy.

Metadata

Metadata

Assignees

Labels

stabilityImprove some sketchy code.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions