Skip to content

Added week5-assignment#14

Open
zyang888 wants to merge 4 commits into
frontend-application-development-uw20:masterfrom
zyang888:master
Open

Added week5-assignment#14
zyang888 wants to merge 4 commits into
frontend-application-development-uw20:masterfrom
zyang888:master

Conversation

@zyang888
Copy link
Copy Markdown

Week 5 HW Submission

Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.

  • Comfort rating on this assignment (1-5): 5
  • Completion rating on this assignment: complete

Comment thread movie/src/App.js

componentDidMount() {
this.state.items.forEach((item) =>
fetch(`http://www.omdbapi.com/?apikey=f95be5bf&t=${item.title}`)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try not to commit your api key!

Comment thread movie/src/App.js
.then((response) =>
this.setState((prev) => ({
res: [...prev.res, response],
}))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a catch block in here too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants