week5 hw#4
Open
ryancfields wants to merge 1 commit into
Open
Conversation
bhague1281
reviewed
May 31, 2020
| "@testing-library/react": "^9.5.0", | ||
| "@testing-library/user-event": "^7.2.1", | ||
| "bootstrap": "^4.5.0", | ||
| "react": "^16.13.1" |
Contributor
There was a problem hiding this comment.
Not sure what happened here, but the dependencies list is missing react-dom, react-router-dom, and react-scripts
| fetch(`https://rickandmortyapi.com/api/character/${id}`) | ||
| .then((res) => res.json()) | ||
| .then((data) => characterDetail(data)); | ||
| }); |
Contributor
There was a problem hiding this comment.
Just for future reference, the example I showed in the week 5 code examples had a mistake. There should be an empty array as a second parameter for useEffect, otherwise it causes an infinite loop and keeps fetching the data unnecessariliy.
https://medium.com/@andrewmyint/infinite-loop-inside-useeffect-react-hooks-6748de62871
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 5 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.